From: "Jiawen Wu" <jiawenwu@trustnetic.com>
To: "'Andrew Lunn'" <andrew@lunn.ch>
Cc: <netdev@vger.kernel.org>, "'Andrew Lunn'" <andrew+netdev@lunn.ch>,
"'David S. Miller'" <davem@davemloft.net>,
"'Eric Dumazet'" <edumazet@google.com>,
"'Jakub Kicinski'" <kuba@kernel.org>,
"'Paolo Abeni'" <pabeni@redhat.com>,
"'Simon Horman'" <horms@kernel.org>,
"'Mengyuan Lou'" <mengyuanlou@net-swift.com>,
<netdev@vger.kernel.org>, "'Andrew Lunn'" <andrew+netdev@lunn.ch>,
"'David S. Miller'" <davem@davemloft.net>,
"'Eric Dumazet'" <edumazet@google.com>,
"'Jakub Kicinski'" <kuba@kernel.org>,
"'Paolo Abeni'" <pabeni@redhat.com>,
"'Simon Horman'" <horms@kernel.org>,
"'Mengyuan Lou'" <mengyuanlou@net-swift.com>
Subject: RE: [PATCH net-next v1 2/7] net: ngbe: improve the reset flow
Date: Wed, 4 Feb 2026 10:20:00 +0800 [thread overview]
Message-ID: <06f101dc957c$c3cd5790$4b6806b0$@trustnetic.com> (raw)
In-Reply-To: <4ddc6f7d-ee6f-48a9-857f-a10448815675@lunn.ch>
On Tue, Feb 3, 2026 9:56 PM, Andrew Lunn wrote:
> > static void ngbe_reset(struct wx *wx)
> > {
> > + int err;
> > +
> > + err = ngbe_reset_hw(wx);
> > + if (err != 0)
>
> The != 0 is a bit odd. It looks like rest of the driver uses if (err)
>
> > + wx_err(wx, "Hardware Error: %d\n", err);
>
> I also wounder if this should be fatal? Should ngbe_reset() be made an
> int function so the error code can be returned?
The error returned by ngbe_reset_hw() indicates that there is a hardware
issue, and the recovery process will be handled in another work queue.
We hope that the driver can continue to complete the remaining software
reset.
next prev parent reply other threads:[~2026-02-04 2:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 7:57 [PATCH net-next v1 0/7] Wangxun improvement and new support Jiawen Wu
2026-02-03 7:57 ` [PATCH net-next v1 1/7] net: ngbe: move the WOL functions to libwx Jiawen Wu
2026-02-03 13:52 ` Andrew Lunn
2026-02-04 2:05 ` Jiawen Wu
2026-02-03 7:57 ` [PATCH net-next v1 2/7] net: ngbe: improve the reset flow Jiawen Wu
2026-02-03 13:56 ` Andrew Lunn
2026-02-04 2:20 ` Jiawen Wu [this message]
2026-02-03 7:57 ` [PATCH net-next v1 3/7] net: wangxun: move reusable PCI driver ops functions into libwx Jiawen Wu
2026-02-04 2:22 ` [net-next,v1,3/7] " Jakub Kicinski
2026-02-04 6:12 ` Jiawen Wu
2026-02-03 7:57 ` [PATCH net-next v1 4/7] net: txgbe: add power management support Jiawen Wu
2026-02-03 7:57 ` [PATCH net-next v1 5/7] net: wangxun: move ethtool_ops.set_channels into libwx Jiawen Wu
2026-02-03 7:57 ` [PATCH net-next v1 6/7] net: wangxun: add Tx timeout process Jiawen Wu
2026-02-03 7:57 ` [PATCH net-next v1 7/7] net: wangxun: add pcie error handler Jiawen Wu
2026-02-04 1:34 ` kernel test robot
2026-02-04 2:22 ` [net-next,v1,7/7] " Jakub Kicinski
2026-02-04 6:10 ` Jiawen Wu
2026-02-04 11:18 ` [PATCH net-next v1 7/7] " kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='06f101dc957c$c3cd5790$4b6806b0$@trustnetic.com' \
--to=jiawenwu@trustnetic.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox