Re: [PATCH net-next 4/5] mptcp: pm: in-kernel: remove mptcp_pm_has_addr_attr_id

[Matthieu Baerts <matttbe@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1279 bytes --]

Hello,

On 03/04/2026 13:29, Matthieu Baerts (NGI0) wrote:
> There is no need to call this helper: it will check if the address ID
> attribute is set, but this attribute has already been parsed previously.
> 
> Indeed, the value has been set in 'entry->addr.id' if it was set and
> positive, which is what we were looking at. Then only looking at this
> already parsed value is enough, not need to re-extract all Netlink
> attributes again.

Sashiko [1] is complaining that endpoints with an ID 0 are now no longer
supported. But they were never supposed to: "ip mptcp endpoint add id 0"
reports an error.

In fact, this patch is for 'net': from what I see, this patch reverts
commit 584f38942626 ("mptcp: add needs_id for netlink appending addr"),
which should not have been introduced. Other tools could happily add
endpoints with an unexpected ID 0.

If that's OK with the net maintainers, I suggest dropping only this
patch: the rest of the series is OK and not related to it. I will send
this exact same patch for 'net' after having adapted the commit message
and added a "Fixes" tag.

[1]
https://sashiko.dev/#/patchset/20260403-net-next-mptcp-msg_eor-misc-v1-0-b0b33bea3fed%40kernel.org

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.