From: Girish Moodalbail <girish.moodalbail@oracle.com>
To: David Miller <davem@davemloft.net>
Cc: pshelar@ovn.org, netdev@vger.kernel.org
Subject: Re: [PATCH net] geneve: maximum value of VNI cannot be used
Date: Thu, 10 Aug 2017 08:58:58 -0700 [thread overview]
Message-ID: <0724a580-49c0-a457-802c-40fde8d040d5@oracle.com> (raw)
In-Reply-To: <20170809.224130.1529052203716251519.davem@davemloft.net>
On 8/9/17 10:41 PM, David Miller wrote:
> From: Girish Moodalbail <girish.moodalbail@oracle.com>
> Date: Tue, 8 Aug 2017 17:26:24 -0700
>
>> Geneve's Virtual Network Identifier (VNI) is 24 bit long, so the range
>> of values for it would be from 0 to 16777215 (2^24 -1). However, one
>> cannot create a geneve device with VNI set to 16777215. This patch fixes
>> this issue.
>>
>> Signed-off-by: Girish Moodalbail <girish.moodalbail@oracle.com>
>
> I always worry that someone, somewhere, might be using this in some
> way and this will break things.
>
> But I'll apply this for now.
>
Thanks David. As per the output of 'ip link help geneve', 16777215 is a valid
value. However, due to incorrect check in the kernel that value was not supported.
$ ip link help geneve |egrep -A1 VNI
Usage: ... geneve id VNI
remote ADDR
prev parent reply other threads:[~2017-08-10 15:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 0:26 [PATCH net] geneve: maximum value of VNI cannot be used Girish Moodalbail
2017-08-10 5:41 ` David Miller
2017-08-10 15:58 ` Girish Moodalbail [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0724a580-49c0-a457-802c-40fde8d040d5@oracle.com \
--to=girish.moodalbail@oracle.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).