From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ashwanth Goli <ashwanth@codeaurora.org>
Subject: Re: [PATCH] ipv6: remove min MTU check for tunnel destinations
Date: Thu, 10 May 2018 19:17:42 +0530
Message-ID: <0738c72c20d60fd2ffa68573951d0ee3@codeaurora.org>
References: <1525028807-5253-1-git-send-email-ashwanth@codeaurora.org>
 <20180501.122223.1661453536072731491.davem@davemloft.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, pabeni@redhat.com, dsahern@gmail.com,
        netdev-owner@vger.kernel.org
To: David Miller <davem@davemloft.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from smtp.codeaurora.org ([198.145.29.96]:44470 "EHLO
        smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1757097AbeEJNrn (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 10 May 2018 09:47:43 -0400
In-Reply-To: <20180501.122223.1661453536072731491.davem@davemloft.net>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 2018-05-01 21:52, David Miller wrote:
> From: Ashwanth Goli <ashwanth@codeaurora.org>
> Date: Mon, 30 Apr 2018 00:36:47 +0530
> 
>> With 749439bfac "fix udpv6 sendmsg crash caused by too small MTU"
>> tunnel dst's that report a MTU less than IPV6_MIN_MTU are broken
>> even for packets that are smaller than IPV6_MIN_MTU.
>> 
>> According to rfc2473#section-7.1
>> 
>>     if the original IPv6 packet is equal or  smaller  than  the
>>     IPv6 minimum link MTU, the tunnel entry-point node
>>     encapsulates the original packet, and subsequently
>>     fragments the resulting IPv6 tunnel packet into IPv6
>>     fragments that do not exceed the Path MTU to the tunnel
>>     exit-point.
>> 
>> This patch drops the MTU check for tunnel destinations.
>> 
>> Signed-off-by: Ashwanth Goli <ashwanth@codeaurora.org>
> 
> RFC 2473 is generally about ipv6 tunnels....
> 
>> -	if (mtu < IPV6_MIN_MTU)
>> +	if (!(rt->dst.flags & DST_XFRM_TUNNEL) && mtu < IPV6_MIN_MTU)
>>  		return -EINVAL;
> 
> But the check you are adding is specifically checking only IPSEC
> tunnels.
> 
> If what you say is true in your commit message, this test must
> more generally trigger for all ipv6 tunnel types, not just IPSEC
> ones.
> 
> If IPSEC tunnels are being targetting in this patch intentionally,
> that needs to be explained in the commit message.

My intention is to fix the issue for IPSEC tunnels. Will resend by 
changing the commit text.