From: David Ahern <dsahern@kernel.org>
To: Coco Li <lixiaoyan@google.com>, Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Neal Cardwell <ncardwell@google.com>,
Mubashir Adnan Qureshi <mubashirq@google.com>,
Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
Jonathan Corbet <corbet@lwn.net>,
Daniel Borkmann <daniel@iogearbox.net>
Cc: netdev@vger.kernel.org, Chao Wu <wwchao@google.com>,
Wei Wang <weiwan@google.com>,
Pradeep Nemavat <pnemavat@google.com>
Subject: Re: [PATCH v1 net-next 1/2] net-device: reorganize net_device fast path variables
Date: Tue, 5 Dec 2023 09:05:49 -0700 [thread overview]
Message-ID: <074c0c5c-3336-416e-aad4-dc1b4a442edd@kernel.org> (raw)
In-Reply-To: <20231204201232.520025-2-lixiaoyan@google.com>
On 12/4/23 1:12 PM, Coco Li wrote:
> Reorganize fast path variables on tx-txrx-rx order
> Fastpath variables end after npinfo.
>
> Below data generated with pahole on x86 architecture.
>
> Fast path variables span cache lines before change: 12
> Fast path variables span cache lines after change: 4
>
> Suggested-by: Eric Dumazet <edumazet@google.com>
> Signed-off-by: Coco Li <lixiaoyan@google.com>
> ---
> include/linux/netdevice.h | 117 +++++++++++++++++++++-----------------
> net/core/dev.c | 56 ++++++++++++++++++
> 2 files changed, 120 insertions(+), 53 deletions(-)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2023-12-05 16:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 20:12 [PATCH v1 net-next 0/2] Reorganize remaining patch of networking struct cachelines Coco Li
2023-12-04 20:12 ` [PATCH v1 net-next 1/2] net-device: reorganize net_device fast path variables Coco Li
2023-12-04 20:30 ` Eric Dumazet
2023-12-05 16:05 ` David Ahern [this message]
2023-12-04 20:12 ` [PATCH v1 net-next 2/2] tcp: reorganize tcp_sock " Coco Li
2023-12-04 20:31 ` Eric Dumazet
2023-12-05 16:08 ` David Ahern
2023-12-06 5:00 ` [PATCH v1 net-next 0/2] Reorganize remaining patch of networking struct cachelines patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=074c0c5c-3336-416e-aad4-dc1b4a442edd@kernel.org \
--to=dsahern@kernel.org \
--cc=andrew@lunn.ch \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=lixiaoyan@google.com \
--cc=mubashirq@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pnemavat@google.com \
--cc=weiwan@google.com \
--cc=wwchao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).