From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f49.google.com ([209.85.160.49]:37212 "EHLO mail-pl0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932419AbeCLCKW (ORCPT ); Sun, 11 Mar 2018 22:10:22 -0400 Received: by mail-pl0-f49.google.com with SMTP id w12-v6so8504982plp.4 for ; Sun, 11 Mar 2018 19:10:22 -0700 (PDT) Subject: Re: [PATCH net-next 4/4] selftests: forwarding: Allow creation of interfaces without a config file To: Ido Schimmel , netdev@vger.kernel.org Cc: davem@davemloft.net, jiri@mellanox.com, mlxsw@mellanox.com References: <20180311075725.15861-1-idosch@mellanox.com> <20180311075725.15861-5-idosch@mellanox.com> From: David Ahern Message-ID: <078a4c6b-61e7-0f9a-c1c7-0b6b5d55d452@gmail.com> Date: Sun, 11 Mar 2018 20:10:20 -0600 MIME-Version: 1.0 In-Reply-To: <20180311075725.15861-5-idosch@mellanox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On 3/11/18 12:57 AM, Ido Schimmel wrote: > Some users want to be able to run the tests without a configuration file > which is useful when one needs to test both virtual and physical > interfaces on the same machine. > > Move the defines that set the type of interface to create and whether to > create it away from the optional configuration file to the library like > the rest of the defines. > > Signed-off-by: Ido Schimmel > Reviewed-by: Jiri Pirko > --- > tools/testing/selftests/net/forwarding/forwarding.config.sample | 9 ++++----- > tools/testing/selftests/net/forwarding/lib.sh | 2 ++ > 2 files changed, 6 insertions(+), 5 deletions(-) > Reviewed-by: David Ahern