From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E61B245BD5F for ; Tue, 30 Jun 2026 15:48:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782834486; cv=none; b=kXz/uTZt3Vf8Iynl9TFGyfIIY0DBtTf4R9KSsRlI3BSH+LZo3KKIXgwqdBh4L4ONJxSVjsK0QvByg82eDQYXXulWLzavBY2bGv1rH5OzYb3ThyyBev1bSbz2s9uHzIu0H/yLlfsxet3OsvsD6eQixL3iYEynslgSS0N59Db95T0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782834486; c=relaxed/simple; bh=twAyy9xwYCSMvApgyBYUMDHVlW/irdnupyHPndRGu7s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dG3JLhRHjbkDo5LTO0Y2vfhJRdIru7JdOCDWsyRqW4M6rWP1ADf814kD0tVjPogJ1OtIZuwOJTYWT7pzhJMCXaLryJgmeu0SxGvDnEZULIIEg/18aY9wdduw8nOENuNXH/ACUK36G6ZB3lznLnOqAWLyVyAuUU9ovt4I4hu0NXA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=FNL25nQv; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=IJ2hcW9M; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="FNL25nQv"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="IJ2hcW9M" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1782834484; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Yl4pxIPjVlnHUWDpO5Lxb9ymfeFrDg7e0YhAWoqeXok=; b=FNL25nQvyZdAK4X30EwDiM3B2l0gHoYysH6jUBYPR3yBRFHoS4Z0FC3ULdfmzHgPs+Xzw/ MyilgLuxgfA6AwXSywbjpHKGWgiEsFYQezb2xi1V1QvaHA/3kJ4zKX/626QsZ4Flcruz19 teZb9AJLsTIXfgJm5hQLzWkxVxaU7tM= Received: from mail-yw1-f198.google.com (mail-yw1-f198.google.com [209.85.128.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-225-0Xt5HJPbNVqT7qCdsamcjQ-1; Tue, 30 Jun 2026 11:48:02 -0400 X-MC-Unique: 0Xt5HJPbNVqT7qCdsamcjQ-1 X-Mimecast-MFC-AGG-ID: 0Xt5HJPbNVqT7qCdsamcjQ_1782834482 Received: by mail-yw1-f198.google.com with SMTP id 00721157ae682-8067fa066bcso13419487b3.1 for ; Tue, 30 Jun 2026 08:48:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1782834482; x=1783439282; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Yl4pxIPjVlnHUWDpO5Lxb9ymfeFrDg7e0YhAWoqeXok=; b=IJ2hcW9MAQ3+5RGNNav0QdpJs+/lGjvDrEq9LexALQREDcqPVhd2UQo93ODmnIO5t6 mHX5ZC4v9ffenC+72widAM/VIpvEBA5UlFhpTPpohM3yTay99lKvj/8V1x0bd2n5utzg NGTPsWo2Is4SrkQieBQllDNwEIray2O0STc7fXQgjUfvi4dFIi0nlfJ8oycFz/Q93Sog jX0tYlnRwC1CTczNVD/KyazIHWYCITDOIvanmC4GQsSFuUuzjVsmSj0bbXSAAICEpzRC t9rpnsJkJC03lwf8ocLZYhY7zq8U0hXYMxy/z1hGOl6TTUN7wpIVsBsw8+ivzt31pLG/ aj/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782834482; x=1783439282; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Yl4pxIPjVlnHUWDpO5Lxb9ymfeFrDg7e0YhAWoqeXok=; b=rizzh/PQ0ACo1ssmWdHRgCN72SOW5nnAyp8zeZJp+OxX3QfJzsDZUH7LG7xofKzzql OYTjgK0Gmykb9eKgQdt8nc6U9hNx+WFCfHZ9XUVIUu1FgReYTLihfJv9PznZ9kZO6eSi eFpxWSFYCfbGVhoTVbOn8nQqtxtEyLV7MYPfelpsTRuPR1nsuigqIUclChW+qW2woV2/ zLeHJBDypG8UBpkVIVbMXIekT7ezFEGB3+kA1AZ3OqyQfOp8hG2F+m9zYj7WIk1OGWdk qZhftV1uL8bH0bW+3fb067S6AphGYzUFp1Kx4/gBpohopqHsAY1875iQEFNBY6Yb0PbJ 0qVA== X-Forwarded-Encrypted: i=1; AHgh+RqvqGkvSv45im3t5GvNMfMqZMubXzeHazqopp49W5CHk/WwGUqAUR3htRbQLgteXlcwVe+DBDI=@vger.kernel.org X-Gm-Message-State: AOJu0YzQdvwbm3ZXgSE/zPrSwkbLs/xxQTOwshExwY3c2+QsYPRpGQt2 oK8xdy2h0aBQEIZOvs+fhEUvEVvDopz2NJOTBEbntv1AVRa2C6SEE7ci9lkDzI66ML9peoPG+l9 Z2lL0oyA5t6ieEr538zSmwPi12haCJpY5wctWoJji4INfNqy34g4pEmANqQ== X-Gm-Gg: AfdE7cmykJwBsp95yR7z38wn41Y66vgwBax61kgCredITmzfdH9fvPiwG+d5YVIKYLq Qr2Vn4fwob1kW5fgC/pDmA/dsLqzFih341gt+sFNhBfzn6NckqSvDFFIEmQH7fOjQhI61JgtN2o IMkOG0r+5fJa+Sxixnq5pgl8rga004HFZqw3jOA+Nk6HfWY1oPrS1PhhpbIkaymTCbu3yZ1Ah6Y PSjr3hPRSGULfmctlk0NBQdE6Ta6PJj75fiycH9RWsmGT9p0HiCrpviYfLEAEN+AkP7Hpg2lz75 hJerjR4qnkeB9QwDaM3a90dIW6ngXsuTPGvqo4cBGsy6XOh4Y/hA2d0F8nSjRm4zzKAMWGOSoug LjNEzDj3jtRGMXXNgXSsqtliwMQz1lVDbKKWlgKKTpaoJUck7Y93FBZjQ2Liucr+g56jborR/aA poplC1pWo3tA== X-Received: by 2002:a05:690c:3588:b0:80c:c6f:1b48 with SMTP id 00721157ae682-8117ff89193mr21073407b3.24.1782834481846; Tue, 30 Jun 2026 08:48:01 -0700 (PDT) X-Received: by 2002:a05:690c:3588:b0:80c:c6f:1b48 with SMTP id 00721157ae682-8117ff89193mr21073027b3.24.1782834481421; Tue, 30 Jun 2026 08:48:01 -0700 (PDT) Received: from ?IPV6:2a0d:3344:5521:6b10:2eb7:f61a:75:4534? ([2a0d:3344:5521:6b10:2eb7:f61a:75:4534]) by smtp.gmail.com with ESMTPSA id 00721157ae682-810ea95254dsm12263797b3.46.2026.06.30.08.47.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jun 2026 08:48:00 -0700 (PDT) Message-ID: <07a9834b-6c68-46ae-8cfe-32e17f32ebe2@redhat.com> Date: Tue, 30 Jun 2026 17:47:57 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net: lan743x: Initialize eth_syslock spinlock before use To: Andrea Righi , Bryan Whitehead , UNGLinuxDriver@microchip.com Cc: Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Raju Lakkaraju , David Thompson , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260626163218.3591486-1-arighi@nvidia.com> From: Paolo Abeni Content-Language: en-US In-Reply-To: <20260626163218.3591486-1-arighi@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/26/26 6:32 PM, Andrea Righi wrote: > lan743x_hardware_init() calls pci11x1x_strap_get_status() during the > PCI11x1x probe sequence. That helper acquires the Ethernet subsystem > hardware lock via lan743x_hs_syslock_acquire(), which relies on > adapter->eth_syslock_spinlock to serialize access. > > The spinlock is currently initialized only after the strap status is > read. With CONFIG_DEBUG_SPINLOCK enabled, taking the zeroed initialized > spinlock can trip the spinlock debug check. > > Fix by initializing adapter->eth_syslock_spinlock before reading the > strap status so the probe path never attempts to lock an uninitialized > spinlock. > > Fixes: 46b777ad9a8c ("net: lan743x: Add support to SGMII 1G and 2.5G") > Cc: stable@vger.kernel.org # v6.0+ > Signed-off-by: Andrea Righi The PW bot is on holiday, no automated notifications for a while. Applied, thanks! /P