From: "Limonciello, Mario" <mario.limonciello@amd.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Evan Quan <evan.quan@amd.com>,
rafael@kernel.org, lenb@kernel.org, alexander.deucher@amd.com,
christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com,
daniel@ffwll.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, mdaenzer@redhat.com,
maarten.lankhorst@linux.intel.com, tzimmermann@suse.de,
hdegoede@redhat.com, jingyuwang_vip@163.com, lijo.lazar@amd.com,
jim.cromie@gmail.com, bellosilicio@gmail.com,
andrealmeid@igalia.com, trix@redhat.com, jsg@jsg.id.au,
arnd@arndb.de, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, amd-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH V4 1/8] drivers/acpi: Add support for Wifi band RF mitigations
Date: Wed, 21 Jun 2023 13:50:34 -0500 [thread overview]
Message-ID: <07ad6860-8ffb-cc6c-a8e5-e8dc4db4e87a@amd.com> (raw)
In-Reply-To: <8d3340de-34f6-47ad-8024-f6f5ecd9c4bb@lunn.ch>
So if we go down this path of CONFIG_WBRF and CONFIG_WBRF_ACPI, another
question would be where should the new "wbrf.c" be stored? The ACPI only
version most certainly made sense in drivers/acpi/wbrf.c, but a generic
version that only has an ACPI implementation right now not so much.
On 6/21/2023 1:30 PM, Andrew Lunn wrote:
>> And consumer would need to call it, but only if CONFIG_WBRF_ACPI isn't set.
> Why? How is ACPI special that it does not need notifiers?
ACPI core does has notifiers that are used, but they don't work the same.
If you look at patch 4, you'll see amdgpu registers and unregisters using
both
acpi_install_notify_handler()
and
acpi_remove_notify_handler()
If we supported both ACPI notifications and non-ACPI notifications
all consumers would have to have support to register and use both types.
>
>> I don't see why it couldn't be a DT/ACPI hybrid solution for ARM64.
> As said somewhere else, nobody does hybrid. In fact, turn it
> around. Why not implement all this in DT, and make X86 hybrid? That
> will make arm, powerpc, risc-v and mips much simpler :-)
>
> Andrew
Doesn't coreboot do something hybrid with device tree? I thought they
generate their ACPI tables from a combination of DT and some static ASL.
next prev parent reply other threads:[~2023-06-21 18:50 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 5:45 [PATCH V4 0/8] Support Wifi RFI interference mitigation feature Evan Quan
2023-06-21 5:45 ` [PATCH V4 1/8] drivers/acpi: Add support for Wifi band RF mitigations Evan Quan
2023-06-21 15:36 ` Andrew Lunn
2023-06-21 15:39 ` Johannes Berg
2023-06-21 16:14 ` Andrew Lunn
2023-06-21 16:23 ` Limonciello, Mario
2023-06-21 16:31 ` Andrew Lunn
2023-06-21 16:40 ` Limonciello, Mario
2023-06-21 17:20 ` Andrew Lunn
2023-06-21 16:37 ` Johannes Berg
2023-06-21 16:15 ` Limonciello, Mario
2023-06-21 16:52 ` Andrew Lunn
2023-06-21 17:08 ` Limonciello, Mario
2023-06-21 17:26 ` Andrew Lunn
2023-06-21 17:43 ` Limonciello, Mario
2023-06-21 18:30 ` Andrew Lunn
2023-06-21 18:50 ` Limonciello, Mario [this message]
2023-06-21 19:25 ` Andrew Lunn
2023-06-21 22:18 ` Johannes Berg
2023-06-22 1:55 ` Andrew Lunn
2023-06-22 20:28 ` Limonciello, Mario
2023-06-22 21:20 ` Andrew Lunn
2023-06-23 14:52 ` Rafael J. Wysocki
2023-06-23 15:57 ` Limonciello, Mario
2023-06-23 16:28 ` Rafael J. Wysocki
2023-06-23 16:48 ` Limonciello, Mario
2023-06-23 17:15 ` Rafael J. Wysocki
2023-06-30 10:37 ` Quan, Evan
2023-06-23 16:38 ` Rafael J. Wysocki
2023-06-21 5:45 ` [PATCH V4 2/8] cfg80211: expose nl80211_chan_width_to_mhz for wide sharing Evan Quan
2023-06-21 5:45 ` [PATCH V4 3/8] wifi: mac80211: Add support for ACPI WBRF Evan Quan
2023-06-21 10:22 ` Johannes Berg
2023-06-21 14:12 ` Limonciello, Mario
2023-06-21 14:25 ` Johannes Berg
2023-06-21 5:45 ` [PATCH V4 4/8] drm/amd/pm: update driver_if and ppsmc headers for coming wbrf feature Evan Quan
2023-06-21 5:46 ` [PATCH V4 5/8] drm/amd/pm: setup the framework to support Wifi RFI mitigation feature Evan Quan
2023-06-21 5:46 ` [PATCH V4 6/8] drm/amd/pm: add flood detection for wbrf events Evan Quan
2023-06-21 5:46 ` [PATCH V4 7/8] drm/amd/pm: enable Wifi RFI mitigation feature support for SMU13.0.0 Evan Quan
2023-06-21 5:46 ` [PATCH V4 8/8] drm/amd/pm: enable Wifi RFI mitigation feature support for SMU13.0.7 Evan Quan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07ad6860-8ffb-cc6c-a8e5-e8dc4db4e87a@amd.com \
--to=mario.limonciello@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andrealmeid@igalia.com \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=bellosilicio@gmail.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=davem@davemloft.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=edumazet@google.com \
--cc=evan.quan@amd.com \
--cc=hdegoede@redhat.com \
--cc=jim.cromie@gmail.com \
--cc=jingyuwang_vip@163.com \
--cc=johannes@sipsolutions.net \
--cc=jsg@jsg.id.au \
--cc=kuba@kernel.org \
--cc=lenb@kernel.org \
--cc=lijo.lazar@amd.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mdaenzer@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rafael@kernel.org \
--cc=trix@redhat.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).