public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Dawid Osuchowski <linux@osuchow.ski>
To: Tony Nguyen <anthony.l.nguyen@intel.com>,
	davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
	edumazet@google.com, andrew+netdev@lunn.ch,
	netdev@vger.kernel.org
Cc: Jakub Staniszewski <jakub.staniszewski@linux.intel.com>,
	przemyslaw.kitszel@intel.com, scott.w.taylor@intel.com,
	stable@vger.kernel.org,
	Dawid Osuchowski <dawid.osuchowski@linux.intel.com>,
	Aleksandr Loktionov <aleksandr.loktionov@intel.com>,
	Paul Menzel <pmenzel@molgen.mpg.de>,
	Rinitha S <sx.rinitha@intel.com>
Subject: Re: [PATCH net 3/8] ice: fix retry for AQ command 0x06EE
Date: Fri, 6 Mar 2026 00:24:45 +0100	[thread overview]
Message-ID: <07f515d2-af41-46f7-9336-28b5ecf36d9b@osuchow.ski> (raw)
In-Reply-To: <20260303231155.2895065-4-anthony.l.nguyen@intel.com>

On 04/03/2026 00:11, Tony Nguyen wrote:
> From: Jakub Staniszewski <jakub.staniszewski@linux.intel.com>
> 
> Executing ethtool -m can fail reporting a netlink I/O error while firmware
> link management holds the i2c bus used to communicate with the module.

Hey Tony,

Writing from my private email address given I was browsing the list [not 
only for Intel drivers ;)] out of curiosity in my spare time and found a 
typo I thought I had addressed when sending to iwl...

> 
> According to Intel(R) Ethernet Controller E810 Datasheet Rev 2.8 [1]
> Section 3.3.10.4 Read/Write SFF EEPROM (0x06EE)
> request should to be retried upon receiving EBUSY from firmware.

During internal review someone (I think it was Aleksandr) pointed out 
the following typo:

	s/should to be retried/should be retried

It seems I might have sent the version without this change present. 
Could I ask Kuba or whoever would pull this in to fix this typo in the 
final commit message that will land in netdev? :D

Thanks,
Dawid

  reply	other threads:[~2026-03-05 23:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-03 23:11 [PATCH net 0/8][pull request] Intel Wired LAN Driver Updates 2026-03-03 (ice, libie, iavf, igb, igc) Tony Nguyen
2026-03-03 23:11 ` [PATCH net 1/8] ice: fix adding AQ LLDP filter for VF Tony Nguyen
2026-03-03 23:11 ` [PATCH net 2/8] ice: reintroduce retry mechanism for indirect AQ Tony Nguyen
2026-03-03 23:11 ` [PATCH net 3/8] ice: fix retry for AQ command 0x06EE Tony Nguyen
2026-03-05 23:24   ` Dawid Osuchowski [this message]
2026-03-05 23:55     ` Tony Nguyen
2026-03-03 23:11 ` [PATCH net 4/8] ice: Fix memory leak in ice_set_ringparam() Tony Nguyen
2026-03-03 23:11 ` [PATCH net 5/8] libie: don't unroll if fwlog isn't supported Tony Nguyen
2026-03-03 23:11 ` [PATCH net 6/8] iavf: fix netdev->max_mtu to respect actual hardware limit Tony Nguyen
2026-03-03 23:11 ` [PATCH net 7/8] igb: Fix trigger of incorrect irq in igb_xsk_wakeup Tony Nguyen
2026-03-03 23:11 ` [PATCH net 8/8] igc: Fix trigger of incorrect irq in igc_xsk_wakeup function Tony Nguyen
2026-03-05  2:40 ` [PATCH net 0/8][pull request] Intel Wired LAN Driver Updates 2026-03-03 (ice, libie, iavf, igb, igc) patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=07f515d2-af41-46f7-9336-28b5ecf36d9b@osuchow.ski \
    --to=linux@osuchow.ski \
    --cc=aleksandr.loktionov@intel.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=dawid.osuchowski@linux.intel.com \
    --cc=edumazet@google.com \
    --cc=jakub.staniszewski@linux.intel.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pmenzel@molgen.mpg.de \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=scott.w.taylor@intel.com \
    --cc=stable@vger.kernel.org \
    --cc=sx.rinitha@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox