Re: [PATCH net v2] net: renesas: rswitch: Fix timestamp feature after all descriptors are used

[Hao Lan <lanhao@huawei.com>]

On 2023/6/8 8:57, Yoshihiro Shimoda wrote:
> Hi again,
> 
>> From: Yoshihiro Shimoda, Sent: Thursday, June 8, 2023 9:21 AM
>>
>> Hi Hao,
>>
>>> From: Hao Lan, Sent: Wednesday, June 7, 2023 8:28 PM
>>> Hello Yoshihiro Shimoda，
>>>
>>> Does your function set the last descriptor to hardware on initialization, but not at other times?
>>
>> The last descriptor initialization is needed at the first time. So, after the initialization,
>> the last setting will not run anymore.
>>
>>> I think rswitch_gwca_ts_queue_fill should be implemented in a separate function,
>>> not use the 'last' distinguish the last descriptor.
>>
>> I got it. I'll modify this patch on v3.
>>
>>> But if it should be setting every cycle, I think rswitch_gwca_queue_ext_ts_fill should
>>> check if the descriptor is the last in the queue and set the LINKFIX flag.
>>
>> Thank you for the comment. The last descriptor should not be setting every cycle.
>> To implement the code for consistency, I think that I should add rswitch_tsdesc_init()
>> rswitch_gwca_queue_format() like rswitch_txdmac_init() and rswitch_gwca_queue_format()
> 
> About ts_queue, it is similar with linkfix, not txdmac. So, now I'm thinking that modifying
> the rswitch_gwca_ts_queue_alloc() is suitable.
> 
> Best regards,
> Yoshihiro Shimoda
> 

Reviewed-by: Hao Lan <lanhao@huawei.com>