From: Andrew Lunn <andrew@lunn.ch>
To: Potin Lai <potin.lai.pt@gmail.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Oliver Neukum <oliver@neukum.org>,
Samuel Mendoza-Jonas <sam@mendozajonas.com>,
Paul Fertser <fercerpav@gmail.com>,
Simon Horman <horms@kernel.org>,
linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Cosmo Chou <cosmo.chou@quantatw.com>,
Mike Hsieh <Mike_Hsieh@quantatw.com>,
Mik Lin <Mik.Lin@quantatw.com>,
Potin Lai <potin.lai@quantatw.com>,
Adrian Ambrozewicz <aambrozewicz@nvidia.com>
Subject: Re: [PATCH 1/2] net: usb: cdc_ether: add NCSI passthrough support
Date: Mon, 7 Sep 2026 20:17:23 +0200 [thread overview]
Message-ID: <08083379-6eb9-441e-a656-0066c9006dd7@lunn.ch> (raw)
In-Reply-To: <20260907-ncsi-over-usb-v1-1-6b74d2f1196c@gmail.com>
> +/* NCSI operates at 100 Mbps */
> +#define NCSI_SPEED_BPS (100 * 1000000)
Why 100Mbps? RGMII is often used, running at 1G.
> +struct cdc_ncsi_priv {
> + struct ncsi_dev *ndev;
> + struct net_device_ops netdev_ops;
> + const struct net_device_ops *orig_netdev_ops;
> +};
> +
> +static int cdc_ncsi_open(struct net_device *net);
> +static int cdc_ncsi_stop(struct net_device *net);
No forward declarations. Move the code around so they are not needed.
Andrew
next prev parent reply other threads:[~2026-09-07 18:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 12:15 [PATCH 0/2] net: add USB CDC Ethernet NCSI support and fix unregister UAF Potin Lai
2026-09-07 12:15 ` [PATCH 1/2] net: usb: cdc_ether: add NCSI passthrough support Potin Lai
2026-09-07 18:17 ` Andrew Lunn [this message]
2026-09-08 12:45 ` Potin Lai
2026-09-08 13:54 ` Andrew Lunn
2026-09-07 12:15 ` [PATCH 2/2] net/ncsi: fix use-after-free in ncsi_unregister_dev() Potin Lai
2026-09-07 18:23 ` [PATCH 0/2] net: add USB CDC Ethernet NCSI support and fix unregister UAF Andrew Lunn
2026-09-08 12:33 ` Potin Lai
2026-09-09 18:42 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08083379-6eb9-441e-a656-0066c9006dd7@lunn.ch \
--to=andrew@lunn.ch \
--cc=Mik.Lin@quantatw.com \
--cc=Mike_Hsieh@quantatw.com \
--cc=aambrozewicz@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=cosmo.chou@quantatw.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fercerpav@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=pabeni@redhat.com \
--cc=potin.lai.pt@gmail.com \
--cc=potin.lai@quantatw.com \
--cc=sam@mendozajonas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox