From: Fernando Fernandez Mancera <fmancera@suse.de>
To: Martin KaFai Lau <martin.lau@linux.dev>, bpf@vger.kernel.org
Cc: 'Alexei Starovoitov ' <ast@kernel.org>,
'Andrii Nakryiko ' <andrii@kernel.org>,
'Daniel Borkmann ' <daniel@iogearbox.net>,
netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH bpf-next] bpf: test_run: Remove ipv6_bpf_stub usage
Date: Tue, 24 Mar 2026 10:55:21 +0100 [thread overview]
Message-ID: <08247bfa-b67b-4c66-aa09-71ebdbca0df0@suse.de> (raw)
In-Reply-To: <20260323225250.1623542-1-martin.lau@linux.dev>
On 3/23/26 11:52 PM, Martin KaFai Lau wrote:
> From: Martin KaFai Lau <martin.lau@kernel.org>
>
> bpf_prog_test_run_skb() uses net->ipv6.ip6_null_entry for
> BPF_PROG_TYPE_LWT_XMIT test runs.
>
> It currently checks ipv6_bpf_stub before using ip6_null_entry.
> ipv6_bpf_stub will be removed by the CONFIG_IPV6=m support removal
> series posted at [1], so switch this check to ipv6_mod_enabled()
> instead.
>
> This change depends on that series [1]. Without it, CONFIG_IPV6=m is
> still possible, and net->ipv6.ip6_null_entry remains NULL until
> the IPv6 module is loaded.
>
> [1] https://lore.kernel.org/netdev/20260320185649.5411-1-fmancera@suse.de/
>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Fernando Fernandez Mancera <fmancera@suse.de>
> Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
> ---
LGTM!
Reviewed-by: Fernando Fernandez Mancera <fmancera@suse.de>
next prev parent reply other threads:[~2026-03-24 9:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 22:52 [PATCH bpf-next] bpf: test_run: Remove ipv6_bpf_stub usage Martin KaFai Lau
2026-03-24 2:16 ` sun jian
2026-03-24 9:55 ` Fernando Fernandez Mancera [this message]
2026-03-24 15:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08247bfa-b67b-4c66-aa09-71ebdbca0df0@suse.de \
--to=fmancera@suse.de \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kuba@kernel.org \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox