From: Hayes Wang <hayeswang@realtek.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"oliver@neukum.org" <oliver@neukum.org>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/2] r8152: Pass driver_info to REALTEK_USB_DEVICE() macro
Date: Mon, 28 Oct 2019 09:41:40 +0000 [thread overview]
Message-ID: <0835B3720019904CB8F7AA43166CEEB2F18EF1C4@RTITMBSVM03.realtek.com.tw> (raw)
In-Reply-To: <20191025105919.689-1-kai.heng.feng@canonical.com>
Kai-Heng Feng [mailto:kai.heng.feng@canonical.com]
> Sent: Friday, October 25, 2019 6:59 PM
[...]
> -#define REALTEK_USB_DEVICE(vend, prod) \
> +#define REALTEK_USB_DEVICE(vend, prod, info) \
> .match_flags = USB_DEVICE_ID_MATCH_DEVICE | \
> USB_DEVICE_ID_MATCH_INT_CLASS, \
> .idVendor = (vend), \
> .idProduct = (prod), \
> - .bInterfaceClass = USB_CLASS_VENDOR_SPEC \
> + .bInterfaceClass = USB_CLASS_VENDOR_SPEC, \
> + .driver_info = (info) \
> }, \
> { \
> .match_flags = USB_DEVICE_ID_MATCH_INT_INFO | \
> @@ -6739,25 +6740,26 @@ static void rtl8152_disconnect(struct
> usb_interface *intf)
> .idProduct = (prod), \
> .bInterfaceClass = USB_CLASS_COMM, \
> .bInterfaceSubClass = USB_CDC_SUBCLASS_ETHERNET, \
> - .bInterfaceProtocol = USB_CDC_PROTO_NONE
> + .bInterfaceProtocol = USB_CDC_PROTO_NONE, \
> + .driver_info = (info) \
This part is for ECM mode. Add driver_info here is useless,
because it is never be used. The driver always changes
the ECM mode to vendor mode.
Best Regards,
Hayes
next prev parent reply other threads:[~2019-10-28 9:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 10:59 [PATCH 1/2] r8152: Pass driver_info to REALTEK_USB_DEVICE() macro Kai-Heng Feng
2019-10-25 10:59 ` [PATCH 2/2] r8152: Add macpassthru support for ThinkPad Thunderbolt 3 Dock Gen 2 Kai-Heng Feng
2019-10-28 3:58 ` Hayes Wang
2019-10-28 4:58 ` Kai-Heng Feng
2019-10-28 9:21 ` Hayes Wang
2019-10-28 9:41 ` Hayes Wang [this message]
2019-10-28 9:52 ` [PATCH 1/2] r8152: Pass driver_info to REALTEK_USB_DEVICE() macro Kai-Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0835B3720019904CB8F7AA43166CEEB2F18EF1C4@RTITMBSVM03.realtek.com.tw \
--to=hayeswang@realtek.com \
--cc=davem@davemloft.net \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox