From: Chris Mi <cmi@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <netdev@vger.kernel.org>, <jiri@nvidia.com>, <saeedm@nvidia.com>
Subject: Re: [PATCH net-next] net: psample: Introduce stubs to remove NIC driver dependency
Date: Wed, 27 Jan 2021 11:42:13 +0800 [thread overview]
Message-ID: <0837f7ce-cdb9-fe3e-ac10-acfc3e35ee30@nvidia.com> (raw)
In-Reply-To: <20210126184955.5f61784a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Hi Jakub,
On 1/27/2021 10:49 AM, Jakub Kicinski wrote:
> On Tue, 26 Jan 2021 22:59:29 +0800 Chris Mi wrote:
>> In order to send sampled packets to userspace, NIC driver calls
>> psample api directly. But it creates a hard dependency on module
>> psample. Introduce psample_ops to remove the hard dependency.
>> It is initialized when psample module is loaded and set to NULL
>> when the module is unloaded.
>>
>> Signed-off-by: Chris Mi <cmi@nvidia.com>
>> Reviewed-by: Jiri Pirko <jiri@nvidia.com>
> This adds a bunch of sparse warnings.
>
> MelVidia has some patch checking infra, right? Any reason this was not
> run through it?
Could you please tell me what's sparse warnings you hit?
Just now I ran ./scripts/checkpatch.pl again without "--ignore
FILE_PATH_CHANGES",
I got the following warning:
WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does
MAINTAINERS need updating?
#128:
new file mode 100644
I'll change it. But I'm not sure if this is the only thing I need to change.
So could you please elaborate? I'll pay attention to it in the future.
Thanks,
Chris
next prev parent reply other threads:[~2021-01-27 6:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 14:59 [PATCH net-next] net: psample: Introduce stubs to remove NIC driver dependency Chris Mi
2021-01-27 2:49 ` Jakub Kicinski
2021-01-27 3:42 ` Chris Mi [this message]
2021-01-27 23:03 ` Saeed Mahameed
2021-01-28 2:34 ` Chris Mi
2021-01-27 4:50 ` Saeed Mahameed
2021-01-27 22:22 ` Jakub Kicinski
2021-01-27 5:49 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0837f7ce-cdb9-fe3e-ac10-acfc3e35ee30@nvidia.com \
--to=cmi@nvidia.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).