From: Andrew Lunn <andrew@lunn.ch>
To: Wei Fang <wei.fang@nxp.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
richardcochran@gmail.com, claudiu.manoil@nxp.com,
vladimir.oltean@nxp.com, xiaoning.wang@nxp.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, fushi.peng@nxp.com,
devicetree@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH net-next 06/12] ptp: netc: add debugfs support to loop back pulse signal
Date: Fri, 11 Jul 2025 15:33:21 +0200 [thread overview]
Message-ID: <083ef067-b628-4dc9-a3e5-ccbb37de3976@lunn.ch> (raw)
In-Reply-To: <20250711065748.250159-7-wei.fang@nxp.com>
> +static void netc_timer_create_debugfs(struct netc_timer *priv)
> +{
> + char debugfs_name[24];
> + struct dentry *root;
> +
> + snprintf(debugfs_name, sizeof(debugfs_name), "netc_timer%d",
> + priv->phc_index);
> + root = debugfs_create_dir(debugfs_name, NULL);
> + if (IS_ERR(root))
> + return;
You should never check the return values from a debugfs_
calls. debugfs is full optional, and the driver should work without
it. debugfs will also happily accept a NULL or error code as a
parameter. So even if debugfs_create_dir() fails, keep going,
debugfs_create_file() won't explode.
Andrew
next prev parent reply other threads:[~2025-07-11 13:33 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 6:57 [PATCH net-next 00/12] Add NETC Timer PTP driver and add PTP support for ENETC v4 Wei Fang
2025-07-11 6:57 ` [PATCH net-next 01/12] dt-bindings: ptp: add bindings for NETC Timer Wei Fang
2025-07-11 13:27 ` Andrew Lunn
2025-07-14 2:32 ` Wei Fang
2025-07-14 5:51 ` Krzysztof Kozlowski
2025-07-14 7:32 ` Wei Fang
2025-07-14 7:35 ` Krzysztof Kozlowski
2025-07-14 9:11 ` Wei Fang
2025-07-14 9:14 ` Krzysztof Kozlowski
2025-07-14 9:56 ` Wei Fang
2025-07-14 10:09 ` Krzysztof Kozlowski
2025-07-14 10:20 ` Krzysztof Kozlowski
2025-07-14 10:30 ` Wei Fang
2025-07-14 10:28 ` Wei Fang
2025-07-14 10:31 ` Vladimir Oltean
2025-07-14 10:43 ` Wei Fang
2025-07-14 11:37 ` Vladimir Oltean
2025-07-14 13:22 ` Wei Fang
2025-07-14 13:56 ` Vladimir Oltean
2025-07-14 14:14 ` Vladimir Oltean
2025-07-15 2:52 ` Wei Fang
2025-07-15 7:02 ` Vladimir Oltean
2025-07-15 7:11 ` Wei Fang
2025-07-14 11:24 ` Krzysztof Kozlowski
2025-07-14 13:43 ` Wei Fang
2025-07-14 14:04 ` Krzysztof Kozlowski
2025-07-11 6:57 ` [PATCH net-next 02/12] ptp: netc: add NETC Timer PTP driver support Wei Fang
2025-07-11 13:25 ` Andrew Lunn
2025-07-14 2:29 ` Wei Fang
2025-07-12 10:43 ` Vadim Fedorenko
2025-07-14 2:57 ` Wei Fang
2025-07-12 11:53 ` kernel test robot
2025-07-14 5:55 ` Krzysztof Kozlowski
2025-07-14 10:11 ` Wei Fang
2025-07-11 6:57 ` [PATCH net-next 03/12] ptp: netc: add PPS support Wei Fang
2025-07-12 16:00 ` kernel test robot
2025-07-11 6:57 ` [PATCH net-next 04/12] ptp: netc: add periodic pulse output support Wei Fang
2025-07-11 6:57 ` [PATCH net-next 05/12] ptp: netc: add external trigger stamp support Wei Fang
2025-07-11 6:57 ` [PATCH net-next 06/12] ptp: netc: add debugfs support to loop back pulse signal Wei Fang
2025-07-11 13:33 ` Andrew Lunn [this message]
2025-07-14 2:33 ` Wei Fang
2025-07-11 6:57 ` [PATCH net-next 07/12] MAINTAINERS: add NETC Timer PTP clock driver section Wei Fang
2025-07-11 6:57 ` [PATCH net-next 08/12] net: enetc: save the parsed information of PTP packet to skb->cb Wei Fang
2025-07-12 10:54 ` Vadim Fedorenko
2025-07-14 3:07 ` Wei Fang
2025-07-11 6:57 ` [PATCH net-next 09/12] net: enetc: Add enetc_update_ptp_sync_msg() to process PTP sync packet Wei Fang
2025-07-12 10:58 ` Vadim Fedorenko
2025-07-11 6:57 ` [PATCH net-next 10/12] net: enetc: remove unnecessary CONFIG_FSL_ENETC_PTP_CLOCK check Wei Fang
2025-07-12 11:29 ` Vadim Fedorenko
2025-07-11 6:57 ` [PATCH net-next 11/12] net: enetc: add PTP synchronization support for ENETC v4 Wei Fang
2025-07-12 16:42 ` kernel test robot
2025-07-11 6:57 ` [PATCH net-next 12/12] net: enetc: don't update sync packet checksum if checksum offload is used Wei Fang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=083ef067-b628-4dc9-a3e5-ccbb37de3976@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=fushi.peng@nxp.com \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=vladimir.oltean@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).