From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpbgau1.qq.com (smtpbgau1.qq.com [54.206.16.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CAE92391832 for ; Mon, 1 Jun 2026 09:38:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=54.206.16.166 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780306689; cv=none; b=fQK14dBIjh0JO5bcIVCB3QzDxQ1bDhXhf0lczp+p6L8qcf/kL6vd0NqOfn98oFaI1xVNKS1Em0uU0Nawngn8MLtZuijNlvz3PGDMq6EGDphRN5zc+zGBIVDdOS0KyhC67TsLypm+F6afUBdEr3WBRDMOqPLycOBRLi/Z5xU3SR8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780306689; c=relaxed/simple; bh=W0CN6+Pe5vVd9h9r3m8yogaRHx/WcpMzX0+7prQSwlo=; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID: MIME-Version:Content-Type; b=MkbZ5qu8BB139aCCuMo2KRsyDsAlzoae2SMxEFHcmIK3aii6EugHlSut1SKVthypbiFGDGWvtjHyzg7PMtWVHfROb2bw8HzLgktrdpd6mZ+o8+9x1TVX7JJBbLOGTCU6GKn03Qn+/1ONQl2ziFNlFUQ6Y5oOHbWP50RY255815c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=trustnetic.com; spf=pass smtp.mailfrom=trustnetic.com; arc=none smtp.client-ip=54.206.16.166 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=trustnetic.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=trustnetic.com X-QQ-mid:Yeas9t1780306621t488t20379 Received: from 3DB253DBDE8942B29385B9DFB0B7E889 (jiawenwu@trustnetic.com [183.156.95.204]) X-QQ-SSF:0000000000000000000000000000000 From: =?utf-8?b?Smlhd2VuIFd1?= X-BIZMAIL-ID: 2833811856653556621 To: "'Loktionov, Aleksandr'" , Cc: "'Mengyuan Lou'" , "'Andrew Lunn'" , "'David S. Miller'" , "'Eric Dumazet'" , "'Jakub Kicinski'" , "'Paolo Abeni'" , "'Richard Cochran'" , "'Russell King'" , "'Keller, Jacob E'" , "'Michal Swiatkowski'" , "'Simon Horman'" , "'Kees Cook'" , "'Zaremba, Larysa'" , "'Ingo Molnar'" , "'Joe Damato'" , "'Breno Leitao'" , =?iso-8859-1?Q?'Uwe_Kleine-K=F6nig_=28The_Capable_Hub=29'?= , "'Johannes Berg'" , "'Fabio Baltieri'" References: <20260601072221.2952-1-jiawenwu@trustnetic.com> <20260601072221.2952-5-jiawenwu@trustnetic.com> In-Reply-To: Subject: RE: [PATCH net-next v4 4/5] net: wangxun: introduce soft quiesce callbacks for AER recovery Date: Mon, 1 Jun 2026 17:37:00 +0800 Message-ID: <085601dcf1aa$325b2280$97116780$@trustnetic.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Content-Language: zh-cn Thread-Index: AQEmZmPiFxLXVQw6wm5cjAUm9/PfJgGkmD0MAfvgRpe3eYNGsA== X-QQ-SENDSIZE: 520 Feedback-ID: Yeas:trustnetic.com:qybglogicsvrgz:qybglogicsvrgz6b-0 X-QQ-XMAILINFO: Mr/o/c6gDciS59L1IPMtMEf9Md+pUJUSD0psYsoB2fPA2VBLaQnT8MlG UGOmeUmdZSEMqq6XFR92zErsTWxV8e2A0Y2ru8R2YmTQoFlLezTSRTU+QVHlzpJty/dZrsC Sx4klyjHp+6uOs9GTXRFvSUVxt4n8hp/sgdZzd/+KxpmSO04Z9l+gW0nhPFcQ9PfWW1gEP8 cTkAI4+Qw5s9MZeKhPU2bCJIxYl9FECGz2J85L7aO2fI5oEsTSl0+P5eDjo5S+wCKH9kAwh 4e0a7CE343nLQBXKCHtU05keZx3GCHXs+dk5lYP/HyiQRGT/ITJZdWUmzOT07WWfwNeWCtt c6EBoyPk8D0m+shqLRnvMZ+XHVSj1EM4WQkrwnO8VVS35JZFJO7TgXB+ckz43z8jOrX7QTa 1DXKoCMYuoC/r5nHTtgOGq7jXpbcB+saOTe+NlDoFyHiDc+aU/+3jsGsIt10RFXMNnN00Md g8h3gh7ekU+1pLcpSvowTeehIb6DbdgvfhtLCOTiVCJvhoBsrkktB5trUvVcYZhPqx1hGiH C1ptkRhmFqW2XPQ/rzT5AYdHmq6x2nI6Y9onpnQv0NRwt0/lEOx8ELdZMND47Onif/eLWQr Fi9WjymNmuboWCDdS+C9kNOmnhWJJdVB1DwrO0wFrAtv8BH1tThDnKZjttox9NQlSIvqxwu ZCXSkGHBtABVVYmnH+DZX1nXALr/Hl+pghAKaVmvc8JXMSLu0N1w+achYO8EoxlEf25eVf8 e+b1luFtpQnw3wLOujfc4RuhAWtmIvuZKq3lx6Gygj+mtj7SRvVx/MZFl3HX03IgiUhiqpJ cH0MnOLDX/UGjT1TgZuAR5W5azI8Nwvdu8imrcCFu/OFvz5f2HoA/KyQiyj5JEnGLEepXNs dW9KTGwjizdzMY79OCrlWmMwYTVtsgmIiO+eDT3DsK0Rht+weMe96mVfc56Xb/pPzpEUaDf +YuDzWBN0tqTRQWO1hEFkhuc+wMwRWhkafCftbWLBNWA78G0NYw8bx8fwHjaZeDnNs8IgWh HKJIhTCT2fIIfitRLklo7xiwCdRamxnsCpfE+ADp3JCCeBKwmpsHOF6a6wD7vZMwQ1M4XEd A== X-QQ-XMRINFO: Mp0Kj//9VHAxzExpfF+O8yhSrljjwrznVg== X-QQ-RECHKSPAM: 0 > > diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c > > b/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c > > index b37c9ed57cf7..816aba4a9099 100644 > > --- a/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c > > +++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_main.c > > @@ -296,6 +296,27 @@ void txgbe_up(struct wx *wx) > > txgbe_up_complete(wx); > > } > > > > +static void txgbe_soft_quiesce(struct wx *wx) { > > + if (test_and_set_bit(WX_STATE_DOWN, wx->state)) > > + return; > > + > > + wx_ptp_stop(wx); > > + phylink_stop(wx->phylink); > > + pci_clear_master(wx->pdev); > > + wx_napi_disable_all(wx); > > + > > + clear_bit(WX_FLAG_NEED_PF_RESET, wx->flags); > > + timer_delete_sync(&wx->service_timer); > > + > > + wx_clean_all_tx_rings(wx); > > + wx_clean_all_rx_rings(wx); > > + > > + wx_free_irq(wx); > > + txgbe_free_misc_irq(wx->priv); > I think wx_free_isb_resources(wx) is missed here, what Sashiko says? > I fill like phylink_disconnect_phy() too. > > Can you prove there is no ISB resources leak? TXGBE is different from NGBE, wx_free_isb_resources() and phylink_disconnect_phy() are not on the close path for TXGBE. > > > + wx_free_resources(wx); > > +} > > + > > /** > > * txgbe_init_type_code - Initialize the shared code > > * @wx: pointer to hardware structure > > @@ -412,6 +433,7 @@ static int txgbe_sw_init(struct wx *wx) > > > > wx->setup_tc = txgbe_setup_tc; > > wx->do_reset = txgbe_do_reset; > > + wx->soft_quiesce = txgbe_soft_quiesce; > > set_bit(0, &wx->fwd_bitmask); > > > > switch (wx->mac.type) { > > -- > > 2.51.0 > >