Re: [PATCH v4 14/14] RDMA/ionic: Add Makefile/Kconfig to kernel build environment

[Shannon Nelson <sln@onemain.com>]

On 7/23/25 10:31 AM, Abhijit Gangurde wrote:
> Add ionic to the kernel build environment.
>
> Co-developed-by: Allen Hubbe <allen.hubbe@amd.com>
> Signed-off-by: Allen Hubbe <allen.hubbe@amd.com>
> Signed-off-by: Abhijit Gangurde <abhijit.gangurde@amd.com>
> ---
> v2->v3
>    - Removed select of ethernet driver
>    - Fixed make htmldocs error
>
>   .../device_drivers/ethernet/index.rst         |  1 +
>   .../ethernet/pensando/ionic_rdma.rst          | 43 +++++++++++++++++++
>   MAINTAINERS                                   |  9 ++++
>   drivers/infiniband/Kconfig                    |  1 +
>   drivers/infiniband/hw/Makefile                |  1 +
>   drivers/infiniband/hw/ionic/Kconfig           | 15 +++++++
>   drivers/infiniband/hw/ionic/Makefile          |  9 ++++
>   7 files changed, 79 insertions(+)
>   create mode 100644 Documentation/networking/device_drivers/ethernet/pensando/ionic_rdma.rst
>   create mode 100644 drivers/infiniband/hw/ionic/Kconfig
>   create mode 100644 drivers/infiniband/hw/ionic/Makefile
>
> diff --git a/Documentation/networking/device_drivers/ethernet/index.rst b/Documentation/networking/device_drivers/ethernet/index.rst
> index 139b4c75a191..4b16ecd289da 100644
> --- a/Documentation/networking/device_drivers/ethernet/index.rst
> +++ b/Documentation/networking/device_drivers/ethernet/index.rst
> @@ -50,6 +50,7 @@ Contents:
>      neterion/s2io
>      netronome/nfp
>      pensando/ionic
> +   pensando/ionic_rdma
>      smsc/smc9
>      stmicro/stmmac
>      ti/cpsw
> diff --git a/Documentation/networking/device_drivers/ethernet/pensando/ionic_rdma.rst b/Documentation/networking/device_drivers/ethernet/pensando/ionic_rdma.rst
> new file mode 100644
> index 000000000000..80c4d9876d3e
> --- /dev/null
> +++ b/Documentation/networking/device_drivers/ethernet/pensando/ionic_rdma.rst
> @@ -0,0 +1,43 @@
> +.. SPDX-License-Identifier: GPL-2.0+
> +
> +============================================================
> +Linux Driver for the AMD Pensando(R) Ethernet adapter family
> +============================================================
> +
> +AMD Pensando RDMA driver.
> +Copyright (C) 2018-2025, Advanced Micro Devices, Inc.
> +
> +Contents
> +========
> +
> +- Identifying the Adapter
> +- Enabling the driver
> +- Support
> +
> +Identifying the Adapter
> +=======================
> +
> +See Documentation/networking/device_drivers/ethernet/pensando/ionic.rst
> +for more information on identifying the adapter.
> +
> +Enabling the driver
> +===================
> +
> +The driver is enabled via the standard kernel configuration system,
> +using the make command::
> +
> +  make oldconfig/menuconfig/etc.
> +
> +The driver is located in the menu structure at:
> +
> +  -> Device Drivers
> +    -> InfiniBand support
> +      -> AMD Pensando DSC RDMA/RoCE Support

Please add some verbage about this being an auxiliary_device dependent 
on the ionic driver, and that it can be disabled/enab led with a devlink 
command.

sln


> +
> +Support
> +=======
> +
> +For general Linux rdma support, please use the rdma mailing
> +list, which is monitored by AMD Pensando personnel::
> +
> +  linux-rdma@vger.kernel.org
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b4f3fa14ddca..f52409bde673 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1165,6 +1165,15 @@ F:	Documentation/networking/device_drivers/ethernet/amd/pds_core.rst
>   F:	drivers/net/ethernet/amd/pds_core/
>   F:	include/linux/pds/
>   
> +AMD PENSANDO RDMA DRIVER
> +M:	Abhijit Gangurde <abhijit.gangurde@amd.com>
> +M:	Allen Hubbe <allen.hubbe@amd.com>
> +L:	linux-rdma@vger.kernel.org
> +S:	Maintained
> +F:	Documentation/networking/device_drivers/ethernet/pensando/ionic_rdma.rst
> +F:	drivers/infiniband/hw/ionic/
> +F:	include/uapi/rdma/ionic-abi.h
> +
>   AMD PMC DRIVER
>   M:	Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
>   L:	platform-driver-x86@vger.kernel.org
> diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig
> index 3a394cd772f6..f0323f1d6f01 100644
> --- a/drivers/infiniband/Kconfig
> +++ b/drivers/infiniband/Kconfig
> @@ -85,6 +85,7 @@ source "drivers/infiniband/hw/efa/Kconfig"
>   source "drivers/infiniband/hw/erdma/Kconfig"
>   source "drivers/infiniband/hw/hfi1/Kconfig"
>   source "drivers/infiniband/hw/hns/Kconfig"
> +source "drivers/infiniband/hw/ionic/Kconfig"
>   source "drivers/infiniband/hw/irdma/Kconfig"
>   source "drivers/infiniband/hw/mana/Kconfig"
>   source "drivers/infiniband/hw/mlx4/Kconfig"
> diff --git a/drivers/infiniband/hw/Makefile b/drivers/infiniband/hw/Makefile
> index df61b2299ec0..b706dc0d0263 100644
> --- a/drivers/infiniband/hw/Makefile
> +++ b/drivers/infiniband/hw/Makefile
> @@ -14,3 +14,4 @@ obj-$(CONFIG_INFINIBAND_HNS_HIP08)	+= hns/
>   obj-$(CONFIG_INFINIBAND_QEDR)		+= qedr/
>   obj-$(CONFIG_INFINIBAND_BNXT_RE)	+= bnxt_re/
>   obj-$(CONFIG_INFINIBAND_ERDMA)		+= erdma/
> +obj-$(CONFIG_INFINIBAND_IONIC)		+= ionic/
> diff --git a/drivers/infiniband/hw/ionic/Kconfig b/drivers/infiniband/hw/ionic/Kconfig
> new file mode 100644
> index 000000000000..de6f10e9b6e9
> --- /dev/null
> +++ b/drivers/infiniband/hw/ionic/Kconfig
> @@ -0,0 +1,15 @@
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (C) 2018-2025, Advanced Micro Devices, Inc.
> +
> +config INFINIBAND_IONIC
> +	tristate "AMD Pensando DSC RDMA/RoCE Support"
> +	depends on NETDEVICES && ETHERNET && PCI && INET && IONIC
> +	help
> +	  This enables RDMA/RoCE support for the AMD Pensando family of
> +	  Distributed Services Cards (DSCs).
> +
> +	  To learn more, visit our website at
> +	  <https://www.amd.com/en/products/accelerators/pensando.html>.
> +
> +	  To compile this driver as a module, choose M here. The module
> +	  will be called ionic_rdma.
> diff --git a/drivers/infiniband/hw/ionic/Makefile b/drivers/infiniband/hw/ionic/Makefile
> new file mode 100644
> index 000000000000..957973742820
> --- /dev/null
> +++ b/drivers/infiniband/hw/ionic/Makefile
> @@ -0,0 +1,9 @@
> +# SPDX-License-Identifier: GPL-2.0
> +
> +ccflags-y :=  -I $(srctree)/drivers/net/ethernet/pensando/ionic
> +
> +obj-$(CONFIG_INFINIBAND_IONIC)	+= ionic_rdma.o
> +
> +ionic_rdma-y :=	\
> +	ionic_ibdev.o ionic_lif_cfg.o ionic_queue.o ionic_pgtbl.o ionic_admin.o \
> +	ionic_controlpath.o ionic_datapath.o ionic_hw_stats.o