From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42604C4167B for ; Wed, 6 Apr 2022 12:48:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231453AbiDFMuZ (ORCPT ); Wed, 6 Apr 2022 08:50:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233711AbiDFMd3 (ORCPT ); Wed, 6 Apr 2022 08:33:29 -0400 Received: from nbd.name (nbd.name [IPv6:2a01:4f8:221:3d45::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CDA236FB5A; Wed, 6 Apr 2022 01:32:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9xt0369dhM7VBOgA77yxeIwkTj0Hpid2gN2MW5LI3oo=; b=LZmSgaDdhGWPzS7AFEj8yCE24S 5jtuV7po7iIM1SI3fgqX0lmSNmiWaMI6X4Hujy0wUAdj3OzCK6osprWGo/NxsY2TNRlHWFJruD966 lsf8d9G0WJ85l6ntJ0YQh/jaBvGBk/tsr5ppdw+cdNXpEl707vUKrc51miM0AYsL7xpk=; Received: from p200300daa70ef200456864e8b8d10029.dip0.t-ipconnect.de ([2003:da:a70e:f200:4568:64e8:b8d1:29] helo=nf.local) by ds12 with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1nc15K-00040V-QC; Wed, 06 Apr 2022 10:32:14 +0200 Message-ID: <08883cf4-27b9-30bf-bd27-9391b763417c@nbd.name> Date: Wed, 6 Apr 2022 10:32:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 04/14] dt-bindings: arm: mediatek: document WED binding for MT7622 Content-Language: en-US To: Arnd Bergmann Cc: Krzysztof Kozlowski , Networking , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Lorenzo Bianconi , DTML , Linux ARM , "moderated list:ARM/Mediatek SoC..." , Linux Kernel Mailing List References: <20220405195755.10817-1-nbd@nbd.name> <20220405195755.10817-5-nbd@nbd.name> From: Felix Fietkau In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 06.04.22 10:29, Arnd Bergmann wrote: > On Wed, Apr 6, 2022 at 10:18 AM Felix Fietkau wrote: >> On 06.04.22 10:09, Krzysztof Kozlowski wrote: >> > On 05/04/2022 21:57, Felix Fietkau wrote: >> >> From: Lorenzo Bianconi >> >> >> >> Document the binding for the Wireless Ethernet Dispatch core on the MT7622 >> >> SoC, which is used for Ethernet->WLAN offloading >> >> Add related info in mediatek-net bindings. >> >> >> >> Signed-off-by: Lorenzo Bianconi >> >> Signed-off-by: Felix Fietkau >> > >> > Thank you for your patch. There is something to discuss/improve. >> > >> >> --- >> >> .../arm/mediatek/mediatek,mt7622-wed.yaml | 50 +++++++++++++++++++ >> >> .../devicetree/bindings/net/mediatek-net.txt | 2 + >> >> 2 files changed, 52 insertions(+) >> >> create mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,mt7622-wed.yaml >> > >> > Don't store drivers in arm directory. See: >> > https://lore.kernel.org/linux-devicetree/YkJa1oLSEP8R4U6y@robh.at.kernel.org/ >> > >> > Isn't this a network offload engine? If yes, then probably it should be >> > in "net/". >> It's not a network offload engine by itself. It's a SoC component that >> connects to the offload engine and controls a MTK PCIe WLAN device, >> intercepting interrupts and DMA rings in order to be able to inject >> packets coming in from the offload engine. >> Do you think it still belongs in net, or maybe in soc instead? > > I think it belongs into drivers/net/. Presumably this has some kind of > user interface to configure which packets are forwarded? I would not > want to maintain that in a SoC driver as this clearly needs to communicate > with both of the normal network devices in some form. The WLAN driver attaches to WED in order to deal with the intercepted DMA rings, but other than that, WED itself has no user configuration. Offload is controlled by the PPE code in the ethernet driver (which is already upstream), and WED simply provides a destination port for PPE, which allows packets to flow to the wireless device. - Felix