From: Shardul Bankar <shardul.b@mpiricsoftware.com>
To: Eric Dumazet <edumazet@google.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
horms@kernel.org, netdev@vger.kernel.org, liuhangbin@gmail.com,
lukma@nabladev.com, acsjakub@amazon.de, kees@kernel.org,
xiaoliang.yang_1@nxp.com, fmancera@suse.de,
linux-kernel@vger.kernel.org, janak@mpiric.us,
kalpan.jani@mpiricsoftware.com,
syzbot+f2fbf7478a35a94c8b7c@syzkaller.appspotmail.com
Subject: Re: [PATCH] net: hsr: avoid synchronize_net() in hsr_del_port() under rtnl_mutex
Date: Sat, 18 Apr 2026 02:42:03 +0530 [thread overview]
Message-ID: <08c2189f7bb66d81c1fc8feff1a56dd7250958d3.camel@mpiricsoftware.com> (raw)
In-Reply-To: <CANn89i+Yug-M2HFnoz5LrffTaB4AHtC74sPKjLWA7cJ2fKF4-w@mail.gmail.com>
On Fri, 2026-04-17 at 11:18 -0700, Eric Dumazet wrote:
> On Fri, Apr 17, 2026 at 10:53 AM Shardul Bankar
> <shardulsb08@gmail.com> wrote:
> >
>
> synchronize_rcu_expedited() should be quite fast...
Confirmed. I ran a targeted HSR-only teardown stress on current
mainline (many HSR-bearing netns torn down concurrently, no WireGuard,
no syzkaller harness). At N=1000, patched-vs-baseline cleanup_net
wall time is within run-to-run noise- the patch has no measurable
benefit on the workload it was meant to address.
> Signature looks like bug fixed recently in wireguard.
>
> commit 60a25ef8dacb3566b1a8c4de00572a498e2a3bf9
Agreed. 60a25ef8dacb covers what I was actually observing, and
standalone evidence for the HSR path on current mainline is not
strong enough to justify this change.
Please drop this patch.
Thanks,
Shardul
prev parent reply other threads:[~2026-04-17 21:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-17 17:53 [PATCH] net: hsr: avoid synchronize_net() in hsr_del_port() under rtnl_mutex Shardul Bankar
2026-04-17 18:18 ` Eric Dumazet
2026-04-17 21:12 ` Shardul Bankar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08c2189f7bb66d81c1fc8feff1a56dd7250958d3.camel@mpiricsoftware.com \
--to=shardul.b@mpiricsoftware.com \
--cc=acsjakub@amazon.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fmancera@suse.de \
--cc=horms@kernel.org \
--cc=janak@mpiric.us \
--cc=kalpan.jani@mpiricsoftware.com \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=lukma@nabladev.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+f2fbf7478a35a94c8b7c@syzkaller.appspotmail.com \
--cc=xiaoliang.yang_1@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox