From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Barmann <david.barmann@stackpath.com>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH v3 net-next] sock: Reset dst when changing sk_mark via setsockopt
Date: Thu, 8 Nov 2018 07:16:43 -0800 [thread overview]
Message-ID: <093ffd5f-d31c-4eb1-cb86-6c0d87a25e78@gmail.com> (raw)
In-Reply-To: <20181108141335.GA29455@konacove.com>
On 11/08/2018 06:13 AM, David Barmann wrote:
> When setting the SO_MARK socket option, if the mark changes, the dst
> needs to be reset so that a new route lookup is performed.
>
> This fixes the case where an application wants to change routing by
> setting a new sk_mark. If this is done after some packets have already
> been sent, the dst is cached and has no effect.
>
> Signed-off-by: David Barmann <david.barmann@stackpath.com>
> ---
Reviewed-by: Eric Dumazet <edumazet@google.com>
Thanks David !
next prev parent reply other threads:[~2018-11-09 0:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 14:13 [PATCH v3 net-next] sock: Reset dst when changing sk_mark via setsockopt David Barmann
2018-11-08 15:16 ` Eric Dumazet [this message]
2018-11-09 3:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=093ffd5f-d31c-4eb1-cb86-6c0d87a25e78@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=david.barmann@stackpath.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).