From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH v3 net-next] sock: Reset dst when changing sk_mark via setsockopt Date: Thu, 8 Nov 2018 07:16:43 -0800 Message-ID: <093ffd5f-d31c-4eb1-cb86-6c0d87a25e78@gmail.com> References: <20181108141335.GA29455@konacove.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: David Barmann , netdev Return-path: Received: from mail-pl1-f194.google.com ([209.85.214.194]:40729 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726509AbeKIAwn (ORCPT ); Thu, 8 Nov 2018 19:52:43 -0500 Received: by mail-pl1-f194.google.com with SMTP id q19-v6so6677013pll.7 for ; Thu, 08 Nov 2018 07:16:46 -0800 (PST) In-Reply-To: <20181108141335.GA29455@konacove.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 11/08/2018 06:13 AM, David Barmann wrote: > When setting the SO_MARK socket option, if the mark changes, the dst > needs to be reset so that a new route lookup is performed. > > This fixes the case where an application wants to change routing by > setting a new sk_mark. If this is done after some packets have already > been sent, the dst is cached and has no effect. > > Signed-off-by: David Barmann > --- Reviewed-by: Eric Dumazet Thanks David !