From: Andrew Lunn <andrew@lunn.ch>
To: Javen <javen_xu@realsil.com.cn>
Cc: "hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"nic_swsd@realtek.com" <nic_swsd@realtek.com>,
"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"horms@kernel.org" <horms@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v4 2/6] r8169: add support for phylink
Date: Mon, 6 Jul 2026 14:57:33 +0200 [thread overview]
Message-ID: <0950251b-bfa8-4ad8-bdc9-a63ea9f14e0f@lunn.ch> (raw)
In-Reply-To: <1f09de5536004055ba63862ca7088eeb@realsil.com.cn>
> >> + if (tp->sfp_mode) {
> >> + phy_mode = PHY_INTERFACE_MODE_INTERNAL;
> >> + tp->phylink_config.mac_capabilities |= MAC_10000FD;
> >
> >Only 10G? Is it not possible to slow down to 1G for a 1G SFP?
>
> It can support 1G SFP as well.
>
> I only added MAC_10000FD here because the original code path only added
> the 10G capability, and I was trying to keep the behavior unchanged in
> this conversion patch.
That is a good reason to keep it the same. But since the hardware can
do 1G, please add a follow up patch adding 1G support.
Andrew
next prev parent reply other threads:[~2026-07-06 12:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-03 9:24 [PATCH net-next v4 0/6] r8169: add support for phylink javen
2026-07-03 9:24 ` [PATCH net-next v4 1/6] r8169: add speed in private struct javen
2026-07-03 20:21 ` Andrew Lunn
2026-07-03 9:24 ` [PATCH net-next v4 2/6] r8169: add support for phylink javen
2026-07-03 20:37 ` Andrew Lunn
2026-07-06 3:07 ` Javen
2026-07-06 12:57 ` Andrew Lunn [this message]
2026-07-03 9:24 ` [PATCH net-next v4 3/6] r8169: add support for RTL8116af javen
2026-07-03 9:24 ` [PATCH net-next v4 4/6] r8169: add ltr support for RTL8117 series javen
2026-07-03 9:24 ` [PATCH net-next v4 5/6] r8169: fix RTL8116af can not enter s0idle and c10 javen
2026-07-03 9:24 ` [PATCH net-next v4 6/6] r8169: add phylink support for RTL8127atf javen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0950251b-bfa8-4ad8-bdc9-a63ea9f14e0f@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=javen_xu@realsil.com.cn \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox