From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F11FC10F00 for ; Sat, 16 Feb 2019 05:37:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3B45C222A1 for ; Sat, 16 Feb 2019 05:37:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726072AbfBPFgO (ORCPT ); Sat, 16 Feb 2019 00:36:14 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:3738 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725794AbfBPFgO (ORCPT ); Sat, 16 Feb 2019 00:36:14 -0500 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 4828FC97BCD0D1D0A11B; Sat, 16 Feb 2019 13:36:08 +0800 (CST) Received: from [127.0.0.1] (10.177.19.180) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.408.0; Sat, 16 Feb 2019 13:35:58 +0800 Subject: Re: [RFC PATCH] bonding: use mutex lock in bond_get_stats() To: Eric Dumazet CC: netdev , Willem de Bruijn , "David S . Miller" , Jay Vosburgh , Veaceslav Falico , References: <20190215135056.18376-1-wangkefeng.wang@huawei.com> From: Kefeng Wang Message-ID: <09569f86-2a12-ccdf-3ae7-00a228d1f957@huawei.com> Date: Sat, 16 Feb 2019 13:35:56 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.19.180] X-CFilter-Loop: Reflected Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2019/2/15 21:57, Eric Dumazet wrote: > On Fri, Feb 15, 2019 at 5:37 AM Kefeng Wang wrote: >> >> With CONFIG_DEBUG_SPINLOCK=y, we find following stack, >> >> BUG: spinlock wrong CPU on CPU#0, ip/16047 >> lock: 0xffff803f5febc998, .magic: dead4ead, .owner: ip/16047, .owner_cpu: 0 >> CPU: 1 PID: 16047 Comm: ip Kdump: loaded Tainted: G E 4.19.12.aarch64 #1 >> Hardware name: Huawei TaiShan 2280 V2/BC82AMDA, BIOS TA BIOS TaiShan 2280 V2 - B900 01/29/2019 >> Call trace: >> dump_backtrace+0x0/0x1c0 >> show_stack+0x24/0x30 >> dump_stack+0x90/0xbc >> spin_dump+0x84/0xa8 >> do_raw_spin_unlock+0xf8/0x100 >> _raw_spin_unlock+0x20/0x30 >> bond_get_stats+0x110/0x140 [bonding] >> rtnl_fill_stats+0x50/0x150 >> rtnl_fill_ifinfo+0x4d4/0xd18 >> rtnl_dump_ifinfo+0x200/0x3a8 >> netlink_dump+0x100/0x2b0 >> netlink_recvmsg+0x310/0x3e8 >> sock_recvmsg+0x58/0x68 >> ___sys_recvmsg+0xd0/0x278 >> __sys_recvmsg+0x74/0xd0 >> __arm64_sys_recvmsg+0x2c/0x38 >> el0_svc_common+0x7c/0x118 >> el0_svc_handler+0x30/0x40 >> el0_svc+0x8/0xc >> >> and then lead to softlockup issue, fix this by using mutex lock instead >> of spin lock. >> >> Signed-off-by: Kefeng Wang >> --- >> >> Not sure if this is right fix, please correct me if I'm wrong. >> > > Make sure to also try : > > cat /proc/net/dev Yes, no regression with this patch in our test or 'cat /proc/net/dev' > > . >