From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 1/2] ravb: kill redundant check in the probe() method Date: Tue, 2 Jan 2018 13:09:52 +0300 Message-ID: <097a0013-17fc-4b74-0993-a672349efe5f@cogentembedded.com> References: <20171231184444.642619406@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit To: netdev@vger.kernel.org, "open list:RENESAS ETHERNET DRIVERS" Return-path: Received: from mail-lf0-f42.google.com ([209.85.215.42]:40822 "EHLO mail-lf0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751495AbeABKJw (ORCPT ); Tue, 2 Jan 2018 05:09:52 -0500 Received: by mail-lf0-f42.google.com with SMTP id u84so35237903lff.7 for ; Tue, 02 Jan 2018 02:09:52 -0800 (PST) In-Reply-To: <20171231184444.642619406@cogentembedded.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: Hello! On 12/31/2017 9:41 PM, Sergei Shtylyov wrote: > Browsing thru the driver diassembly, I noticed that gcc was able to Aw, it's disassembly! DaveM, is that worth reposting? > figure out that the 'ndev' pointer is always non-NULL when calling > free_netdev() on the probe() method's error path and thus skip that > redundant NULL check... gcc is smart, be like gcc! > > Signed-off-by: Sergei Shtylyov [...] MBR, Sergei