netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
	Stefano Brivio <sbrivio@redhat.com>,
	Sabrina Dubroca <sd@queasysnail.net>
Subject: Re: [PATCH net v3 2/2] selftests: pmtu: add explicit tests for PMTU exceptions cleanup
Date: Wed, 27 Feb 2019 09:18:16 -0700	[thread overview]
Message-ID: <097dd04a-8bb1-7870-36a0-3ae5f071137f@gmail.com> (raw)
In-Reply-To: <acec2def2f7f6d254c539c9dd5fb2001f1845524.1551106591.git.pabeni@redhat.com>

On 2/25/19 8:08 AM, Paolo Abeni wrote:
> Add a couple of new tests, explicitly checking that the kernel
> timely releases PMTU exceptions on related device removal.
> This is mostly a regression test vs the issue fixed by
> commit f5b51fe804ec ("ipv6: route: purge exception on removal")
> 
> Only 2 new test cases have been added, instead of extending all
> the existing ones, because the reproducer requires executing
> several commands and would slow down too much the tests otherwise.
> 
> v2 -> v3:
>  - more cleanup, still from Stefano
> 
> v1 -> v2:
>  - several script cleanups, as suggested by Stefano
> 
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> ---
>  tools/testing/selftests/net/pmtu.sh | 68 ++++++++++++++++++++++++++++-
>  1 file changed, 67 insertions(+), 1 deletion(-)
> 

Reviewed-by: David Ahern <dsahern@gmail.com>

Thanks for adding the tests.

  reply	other threads:[~2019-02-27 16:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-25 15:08 [PATCH net v3 0/2] selftests: pmtu: fix and increase coverage Paolo Abeni
2019-02-25 15:08 ` [PATCH net v3 1/2] selftests: pmtu: disable DAD in all namespaces Paolo Abeni
2019-02-25 15:08 ` [PATCH net v3 2/2] selftests: pmtu: add explicit tests for PMTU exceptions cleanup Paolo Abeni
2019-02-27 16:18   ` David Ahern [this message]
2019-02-25 17:46 ` [PATCH net v3 0/2] selftests: pmtu: fix and increase coverage Stefano Brivio
2019-02-28  5:29 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=097dd04a-8bb1-7870-36a0-3ae5f071137f@gmail.com \
    --to=dsahern@gmail.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sbrivio@redhat.com \
    --cc=sd@queasysnail.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).