From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shuah Khan Subject: Re: [PATCH 2/3] selftests: actually run the various net selftests Date: Mon, 18 Sep 2017 16:14:41 -0600 Message-ID: <09f17145-5f0a-ec61-3dfb-69216eac7133@kernel.org> References: <1505755982-7855-1-git-send-email-jbacik@fb.com> <1505755982-7855-2-git-send-email-jbacik@fb.com> Reply-To: shuah@kernel.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: Josef Bacik , "David S. Miller" , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, netdev@vger.kernel.org, Shuah Khan , Shuah Khan To: josef@toxicpanda.com Return-path: In-Reply-To: <1505755982-7855-2-git-send-email-jbacik@fb.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 09/18/2017 11:32 AM, josef@toxicpanda.com wrote: > From: Josef Bacik > > These self tests are just self contained binaries, they are not run by > any of the scripts in the directory. This means they need to be marked > with TEST_GEN_PROGS to actually be run, not TEST_GEN_FILES. > > Signed-off-by: Josef Bacik > --- > tools/testing/selftests/net/Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile > index 3df542c84610..45a4e77a47c4 100644 > --- a/tools/testing/selftests/net/Makefile > +++ b/tools/testing/selftests/net/Makefile > @@ -6,8 +6,8 @@ CFLAGS += -I../../../../usr/include/ > TEST_PROGS := run_netsocktests run_afpackettests test_bpf.sh netdevice.sh rtnetlink.sh > TEST_GEN_FILES = socket > TEST_GEN_FILES += psock_fanout psock_tpacket > -TEST_GEN_FILES += reuseport_bpf reuseport_bpf_cpu reuseport_bpf_numa > -TEST_GEN_FILES += reuseport_dualstack msg_zerocopy reuseaddr_conflict > +TEST_GEN_PROGS += reuseport_bpf reuseport_bpf_cpu reuseport_bpf_numa > +TEST_GEN_PROGS += reuseport_dualstack msg_zerocopy reuseaddr_conflict Hmm. I see msg_zerocopy.sh for running msg_zerocopy. msg_zerocopy should still stay in TEST_GEN_FILES and msg_zerocopy.sh needs to be added to TEST_PROGS so it runs. thanks, -- Shuah