From: Florian Fainelli <f.fainelli@gmail.com>
To: Jon Mason <jon.mason@broadcom.com>, Liviu Dudau <liviu@dudau.co.uk>
Cc: David Miller <davem@davemloft.net>, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Network Development <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>
Subject: Re: [PATCH net-next] net: phy: use of_mdio_parse_addr
Date: Wed, 7 Jun 2017 13:54:16 -0700 [thread overview]
Message-ID: <09fe3523-ab79-c854-c00f-41fe4c55064b@gmail.com> (raw)
In-Reply-To: <CAC3K-4pH51jhKyEfq0mYDNz-+ir5VRe_Kzb082Gd+wiAxiGF7Q@mail.gmail.com>
On 06/07/2017 01:53 PM, Jon Mason wrote:
> On Wed, Jun 7, 2017 at 12:18 PM, Liviu Dudau <liviu@dudau.co.uk> wrote:
>> On Fri, Jun 02, 2017 at 02:22:51PM -0400, David Miller wrote:
>>> From: Jon Mason <jon.mason@broadcom.com>
>>> Date: Wed, 31 May 2017 15:43:30 -0400
>>>
>>>> use of_mdio_parse_addr() in place of an OF read of reg and a bounds
>>>> check (which is litterally the exact same thing that
>>>> of_mdio_parse_addr() does)
>>>>
>>>> Signed-off-by: Jon Mason <jon.mason@broadcom.com>
>>>
>>> Applied, thanks Jon.
>>
>> This makes linux-next fail the modules_install target as depmod detects 2 circular
>> dependencies. Reverting this patch fixes the issue.
>>
>> depmod: ERROR: Cycle detected: libphy -> of_mdio -> fixed_phy -> libphy
>> depmod: ERROR: Cycle detected: libphy -> of_mdio -> libphy
>> depmod: ERROR: Found 3 modules in dependency cycles!
>> make[1]: *** [/home/dliviu/devel/kernel/Makefile:1245: _modinst_post] Error 1
>
> I did not test this as modules. Sorry.
>
> It would be ugly to duplicate the code in both place, and the code in
> question does not seem to really need to be in a C file. Perhaps it
> can be moved to a header file as an inline function, which would solve
> this dependency. Would this be acceptable?
You read my mind, was just going to suggest doing that.
--
Florian
next prev parent reply other threads:[~2017-06-07 20:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 19:43 [PATCH net-next] net: phy: use of_mdio_parse_addr Jon Mason
2017-05-31 20:01 ` Andrew Lunn
2017-05-31 20:01 ` Florian Fainelli
2017-06-02 18:22 ` David Miller
2017-06-07 16:18 ` Liviu Dudau
2017-06-07 20:53 ` Jon Mason
2017-06-07 20:54 ` Florian Fainelli [this message]
2017-06-09 9:00 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09fe3523-ab79-c854-c00f-41fe4c55064b@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=jon.mason@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu@dudau.co.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).