From: Luka Gejak <luka.gejak@linux.dev>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
netdev@vger.kernel.org, fmaurer@redhat.com, horms@kernel.org,
luka.gejak@linux.dev
Subject: Re: [PATCH net-next v5 1/2] net: hsr: require valid EOT supervision TLV
Date: Sun, 12 Apr 2026 22:46:48 +0200 [thread overview]
Message-ID: <0CA147BE-C5AD-4B02-BE57-B586218B52A2@linux.dev> (raw)
In-Reply-To: <20260412133157.3b335e1b@kernel.org>
On April 12, 2026 10:31:57 PM GMT+02:00, Jakub Kicinski <kuba@kernel.org> wrote:
>On Sun, 12 Apr 2026 22:13:35 +0200 Luka Gejak wrote:
>> Regarding the TLV loop: I actually implemented a TLV walker in v4 [1]
>> for this exact reason, but I moved to strict sequential parsing in v5
>> based on reviewer's feedback to keep the implementation simple. Could
>> you please check if the approach used in v4 is what you had in mind?
>> If so, I will rebase that logic onto the memory safety fixes
>> (pskb_may_pull) from v5 and submit it as v6.
>
>That's not really what I had in mind. I was thinking of a loop which
>just skips the TLVs in order, leaving the parsing of known TLVs as is.
>But I've never used HSR maybe this sort of strict validation is somehow
>okay in HSR deployments.
>
>Please just undo the comment tweaks then.
So keep other changes as is and only undo comment changes?
next prev parent reply other threads:[~2026-04-12 20:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 16:25 [PATCH net-next v5 0/2] net: hsr: strict supervision TLV validation luka.gejak
2026-04-07 16:25 ` [PATCH net-next v5 1/2] net: hsr: require valid EOT supervision TLV luka.gejak
2026-04-08 7:48 ` Fernando Fernandez Mancera
2026-04-08 8:05 ` Fernando Fernandez Mancera
2026-04-08 8:19 ` Luka Gejak
2026-04-08 9:32 ` Felix Maurer
2026-04-12 19:45 ` Jakub Kicinski
2026-04-12 20:13 ` Luka Gejak
2026-04-12 20:31 ` Jakub Kicinski
2026-04-12 20:46 ` Luka Gejak [this message]
2026-04-12 21:13 ` Jakub Kicinski
2026-04-13 9:14 ` Felix Maurer
2026-04-07 16:25 ` [PATCH net-next v5 2/2] net: hsr: reject unresolved interlink ifindex luka.gejak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0CA147BE-C5AD-4B02-BE57-B586218B52A2@linux.dev \
--to=luka.gejak@linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fmaurer@redhat.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox