netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Yick Xie <yick.xie@gmail.com>,
	willemdebruijn.kernel@gmail.com,  willemb@google.com
Cc: netdev@vger.kernel.org, davem@davemloft.net, dsahern@kernel.org,
	 edumazet@google.com, kuba@kernel.org,
	linux-kernel@vger.kernel.org,  stable@vger.kernel.org
Subject: Re: [PATCH net v2] udp: don't be set unconnected if only UDP cmsg
Date: Thu, 18 Apr 2024 12:32:38 +0200	[thread overview]
Message-ID: <0a17d6745d5c6d4bb635cfac1029e90c1ac2c676.camel@redhat.com> (raw)
In-Reply-To: <20240416190330.492972-1-yick.xie@gmail.com>

Hi,

On Wed, 2024-04-17 at 03:03 +0800, Yick Xie wrote:
> If "udp_cmsg_send()" returned 0 (i.e. only UDP cmsg),
> "connected" should not be set to 0. Otherwise it stops
> the connected socket from using the cached route.
> 
> Fixes: 2e8de8576343 ("udp: add gso segment cmsg")
> Signed-off-by: Yick Xie <yick.xie@gmail.com>
> Cc: stable@vger.kernel.org

Minor: the patch subj is IMHO a bit confusing, what about removing the
double negation?

preserve connect status with UDP-only cmsg

> ---
> v2: Add Fixes tag
> v1: https://lore.kernel.org/netdev/20240414195213.106209-1-yick.xie@gmail.com/
> ---
>  net/ipv4/udp.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
> index c02bf011d4a6..420905be5f30 100644
> --- a/net/ipv4/udp.c
> +++ b/net/ipv4/udp.c

What about ipv6? why this fix does not apply there, too?

Thanks!

Paolo


  parent reply	other threads:[~2024-04-18 10:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-16 19:03 [PATCH net v2] udp: don't be set unconnected if only UDP cmsg Yick Xie
2024-04-16 23:04 ` Willem de Bruijn
2024-04-18 10:32 ` Paolo Abeni [this message]
2024-04-18 13:52   ` Willem de Bruijn
2024-04-18 17:06     ` [PATCH net v3] udp: preserve the connected status " Yick Xie
2024-04-18 19:38       ` Willem de Bruijn
2024-04-20  3:30       ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0a17d6745d5c6d4bb635cfac1029e90c1ac2c676.camel@redhat.com \
    --to=pabeni@redhat.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=willemb@google.com \
    --cc=willemdebruijn.kernel@gmail.com \
    --cc=yick.xie@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).