Re: [PATCH v17 01/22] cxl: Add type2 device basic support

[Dave Jiang <dave.jiang@intel.com>]

On 8/5/25 3:45 AM, Alejandro Lucero Palau wrote:
> 
> On 7/25/25 22:46, dan.j.williams@intel.com wrote:
>> alejandro.lucero-palau@ wrote:
>>> From: Alejandro Lucero <alucerop@amd.com>
>>>
>>> Differentiate CXL memory expanders (type 3) from CXL device accelerators
>>> (type 2) with a new function for initializing cxl_dev_state and a macro
>>> for helping accel drivers to embed cxl_dev_state inside a private
>>> struct.
>>>
>>> Move structs to include/cxl as the size of the accel driver private
>>> struct embedding cxl_dev_state needs to know the size of this struct.
>>>
>>> Use same new initialization with the type3 pci driver.
>>>
>>> Signed-off-by: Alejandro Lucero <alucerop@amd.com>
>>> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>>> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
>>> Reviewed-by: Alison Schofield <alison.schofield@intel.com>
>>> ---
>>>   drivers/cxl/core/mbox.c      |  12 +-
>>>   drivers/cxl/core/memdev.c    |  32 +++++
>>>   drivers/cxl/core/pci.c       |   1 +
>>>   drivers/cxl/core/regs.c      |   1 +
>>>   drivers/cxl/cxl.h            |  97 +--------------
>>>   drivers/cxl/cxlmem.h         |  85 +------------
>>>   drivers/cxl/cxlpci.h         |  21 ----
>>>   drivers/cxl/pci.c            |  17 +--
>>>   include/cxl/cxl.h            | 226 +++++++++++++++++++++++++++++++++++
>>>   include/cxl/pci.h            |  23 ++++
>>>   tools/testing/cxl/test/mem.c |   3 +-
>>>   11 files changed, 303 insertions(+), 215 deletions(-)
>>>   create mode 100644 include/cxl/cxl.h
>>>   create mode 100644 include/cxl/pci.h
>> Thanks for the updates.
>>
>> Now, I notice this drops some objects out of the existing documentation
>> given some kdoc moves out of drivers/cxl/. The patch below fixes that
>> up, but then uncovers some other Documentation build problems:
>>
>> $ make -j14 htmldocs SPHINXDIRS="driver-api/cxl/"
>> make[3]: Nothing to be done for 'html'.
>> Using alabaster theme
>> source directory: driver-api/cxl
>> ./include/cxl/cxl.h:24: warning: Enum value 'CXL_DEVTYPE_DEVMEM' not described in enum 'cxl_devtype'
>> ./include/cxl/cxl.h:24: warning: Enum value 'CXL_DEVTYPE_CLASSMEM' not described in enum 'cxl_devtype'
>> ./include/cxl/cxl.h:225: warning: expecting prototype for cxl_dev_state_create(). Prototype was for devm_cxl_dev_state_create() instead
> 
> 
> OK.  I can fix those problems easily (bad punctuation). I can not see the one about the prototype, but maybe it is due to the base commit. BTW, which one should I use for next version and rebasing on Terry's patches?

Latest against upstream RC is usually preferred. So 6.17-rc1 is probably the earliest.

DJ

> 
> 
> Thanks
> 
> 
>> Note, this file was renamed in v6.16 to theory-of-operation.rst,
>> git-apply can usually figure that out.
>>
>> cxlpci.h is not currently referenced in the documentation build since it
>> has not kdoc, so no need for a new include/cxl/pci.h entry, but
>> something to look out for if a later patch adds some kdoc.
>>
>> -- 8< --
>> diff --git a/Documentation/driver-api/cxl/memory-devices.rst b/Documentation/driver-api/cxl/memory-devices.rst
>> index d732c42526df..ddaee57b80d0 100644
>> --- a/Documentation/driver-api/cxl/memory-devices.rst
>> +++ b/Documentation/driver-api/cxl/memory-devices.rst
>> @@ -344,6 +344,9 @@ CXL Core
>>   .. kernel-doc:: drivers/cxl/cxl.h
>>      :doc: cxl objects
>>   +.. kernel-doc:: include/cxl/cxl.h
>> +   :internal:
>> +
>>   .. kernel-doc:: drivers/cxl/cxl.h
>>      :internal: