From: YueHaibing <yuehaibing@huawei.com>
To: David Miller <davem@davemloft.net>
Cc: <joe@perches.com>, <gregkh@linuxfoundation.org>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH] appletalk: Fix use-after-free in atalk_proc_exit
Date: Thu, 28 Feb 2019 09:19:51 +0800 [thread overview]
Message-ID: <0a430e08-b7ad-1f87-19a7-40429c09bba0@huawei.com> (raw)
In-Reply-To: <20190227.101459.1829634170038511470.davem@davemloft.net>
On 2019/2/28 2:14, David Miller wrote:
> From: Yue Haibing <yuehaibing@huawei.com>
> Date: Wed, 27 Feb 2019 22:59:00 +0800
>
>> @@ -1925,7 +1925,10 @@ static int __init atalk_init(void)
>>
>> register_netdevice_notifier(&ddp_notifier);
>> aarp_proto_init();
>> - atalk_proc_init();
>> + rc = atalk_proc_init();
>> + if (rc)
>> + goto out;
>> +
>> atalk_register_sysctl();
>> out:
>
> This leaves the netdevice notifier registered etc. You need to add a proper
> error cleanup code path.
Oh, yes, I will do it.
Thanks!
>
> .
>
prev parent reply other threads:[~2019-02-28 1:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 14:59 [PATCH] appletalk: Fix use-after-free in atalk_proc_exit Yue Haibing
2019-02-27 18:14 ` David Miller
2019-02-28 1:19 ` YueHaibing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a430e08-b7ad-1f87-19a7-40429c09bba0@huawei.com \
--to=yuehaibing@huawei.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox