From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Petr Oros <poros@redhat.com>
Cc: <netdev@vger.kernel.org>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
"Mitch Williams" <mitch.a.williams@intel.com>,
Aaron Brown <aaron.f.brown@intel.com>,
Przemyslaw Patynowski <przemyslawx.patynowski@intel.com>,
Jedrzej Jagielski <jedrzej.jagielski@intel.com>,
<intel-wired-lan@lists.osuosl.org>,
<linux-kernel@vger.kernel.org>, <jacob.e.keller@intel.com>
Subject: Re: [PATCH iwl-net v2 0/4] iavf: fix VLAN filter state machine races
Date: Fri, 17 Apr 2026 17:22:13 +0200 [thread overview]
Message-ID: <0a78a89a-1f2f-4ee4-9b9a-74e824511380@intel.com> (raw)
In-Reply-To: <cover.1776426683.git.poros@redhat.com>
On 4/17/26 16:29, Petr Oros wrote:
> The iavf VLAN filter state machine has several design issues that lead
> to race conditions between userspace add/del calls and the watchdog
> task's virtchnl processing. Filters can get lost or leak HW resources,
> especially during interface down/up cycles and namespace moves.
>
[...]
>
> v2: Retarget from iwl-next to iwl-net; these are bug fixes.
> Rebase on current net tree (conflict resolved).
>
> Petr Oros (4):
> iavf: rename IAVF_VLAN_IS_NEW to IAVF_VLAN_ADDING
> iavf: stop removing VLAN filters from PF on interface down
> iavf: wait for PF confirmation before removing VLAN filters
> iavf: add VIRTCHNL_OP_ADD_VLAN to success completion handler
>
> drivers/net/ethernet/intel/iavf/iavf.h | 9 +--
> drivers/net/ethernet/intel/iavf/iavf_main.c | 52 +++----------
> .../net/ethernet/intel/iavf/iavf_virtchnl.c | 76 +++++++++----------
> 3 files changed, 52 insertions(+), 85 deletions(-)
>
Thank you for the series, it looks good.
Also thanks for the not obvious details, like changing
list_for_each_entry_safe() -> list_for_each_entry() in places that
no longer alter the list
for the series:
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
prev parent reply other threads:[~2026-04-17 15:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-17 14:29 [PATCH iwl-net v2 0/4] iavf: fix VLAN filter state machine races Petr Oros
2026-04-17 14:29 ` [PATCH iwl-net v2 1/4] iavf: rename IAVF_VLAN_IS_NEW to IAVF_VLAN_ADDING Petr Oros
2026-04-17 14:29 ` [PATCH iwl-net v2 2/4] iavf: stop removing VLAN filters from PF on interface down Petr Oros
2026-04-17 14:29 ` [PATCH iwl-net v2 3/4] iavf: wait for PF confirmation before removing VLAN filters Petr Oros
2026-04-17 14:29 ` [PATCH iwl-net v2 4/4] iavf: add VIRTCHNL_OP_ADD_VLAN to success completion handler Petr Oros
2026-04-17 15:22 ` Przemek Kitszel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a78a89a-1f2f-4ee4-9b9a-74e824511380@intel.com \
--to=przemyslaw.kitszel@intel.com \
--cc=aaron.f.brown@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=jedrzej.jagielski@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=poros@redhat.com \
--cc=przemyslawx.patynowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox