Re: Potential invalid ~ operator in net/mac80211/cfg.c

[Johannes Berg <johannes@sipsolutions.net>]

On Fri, 2021-02-05 at 18:20 +0000, Colin Ian King wrote:
> 
> > > https://lore.kernel.org/linux-wireless/516C0C7F.3000204@openwrt.org/
> > > 
> > > But maybe that isn't actually quite right due to integer promotion?
> > > OTOH, that's a u8, so it should do the ~ in u8 space, and then compare
> > > to 0 also?
> > 
> > rc_rateidx_vht_mcs_mask is a u64, so I think the expression could be
> > expressed as:
> 
> oops, fat fingered that, it is a u16 not a u64

Right, u16, I must've looked at some ancient version or something.

But no, I was obviously wrong with what I said above.

So of course the condition is always true, like you said.

However, what was intended doesn't look like !, but rather == 0xff and
== 0xffff respectively, I'll send a patch.

johannes