From: Paolo Abeni <pabeni@redhat.com>
To: Kuniyuki Iwashima <kuniyu@amazon.com>, linmiaohe@huawei.com
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net: skbuff: fix missing a __noreturn annotation warning
Date: Tue, 30 May 2023 12:28:25 +0200 [thread overview]
Message-ID: <0ab4f3ea2bd97c7067ed332c0128829f4a7ea596.camel@redhat.com> (raw)
In-Reply-To: <20230527040038.6783-1-kuniyu@amazon.com>
On Fri, 2023-05-26 at 21:00 -0700, Kuniyuki Iwashima wrote:
> From: Miaohe Lin <linmiaohe@huawei.com>
> Date: Sat, 27 May 2023 19:04:09 +0800
> > Add __noreturn annotation to fix the warning:
> > net/core/skbuff.o: warning: objtool: skb_push+0x3c: skb_panic() is missing a __noreturn annotation
> > net/core/skbuff.o: warning: objtool: skb_put+0x4e: skb_panic() is missing a __noreturn annotation
>
> What arch are you using ?
>
> IIUC, BUG() should have an annotation for objtool, for
> example, __builtin_unreachable() for x86.
>
> Maybe the arch is missing such an annotation ?
>
> Also I'm curious why objtool complains about only skb_push(),
> there should be more non-inline functions that has BUG().
AFAICS, the BUG() macro implementation should already carry the
__noreturn annotation, via panic() or other arch-specific way.
This looks like the old toolchain not being able to
successfully/correctly propagate the annotation???
I think we can drop this patch.
Cheers,
Paolo
next prev parent reply other threads:[~2023-05-30 10:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-27 11:04 [PATCH] net: skbuff: fix missing a __noreturn annotation warning Miaohe Lin
2023-05-27 4:00 ` Kuniyuki Iwashima
2023-05-27 9:22 ` Miaohe Lin
2023-05-30 10:28 ` Paolo Abeni [this message]
2023-06-03 3:09 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ab4f3ea2bd97c7067ed332c0128829f4a7ea596.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).