public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Tariq Toukan <ttoukan.linux@gmail.com>
To: Kenta Akagi <k@mgml.me>, Saeed Mahameed <saeedm@nvidia.com>,
	Tariq Toukan <tariqt@nvidia.com>, Mark Bloch <mbloch@nvidia.com>,
	Leon Romanovsky <leon@kernel.org>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC mlx5-next 0/1] net/mlx5e: Expose physical received bits counters to ethtool
Date: Tue, 13 Jan 2026 08:31:57 +0200	[thread overview]
Message-ID: <0ac69f6a-d587-45a7-be30-6ad4429ef8d2@gmail.com> (raw)
In-Reply-To: <20260112070324.38819-1-k@mgml.me>



On 12/01/2026 9:03, Kenta Akagi wrote:
> Hi,
> 
> I would like to measure the cable BER on ConnectX.
> 
> According to the documentation[1][2], there are counters that can be used
> for this purpose: rx_corrected_bits_phy, rx_pcs_symbol_err_phy and
> rx_bits_phy. However, rx_bits_phy does not show up in ethtool
> statistics.
> 
> This patch exposes the PPCNT phy_received_bits as rx_bits_phy.
> 
> 
> On a ConnectX-5 with 25Gbase connection, it works as expected.
> 
> On the other hand, although I have not verified it, in an 800Gbps
> environment rx_bits_phy would likely overflow after about 124 days.
> Since I cannot judge whether this is acceptable, I am posting this as an
> RFC first.
> 

Hi,

This is a 64-bits counter so no overflow is expected.

> 
> [1] commit 8ce3b586faa4 ("net/mlx5: Add counter information to mlx5
>      driver documentation")
> [2] https://docs.kernel.org/networking/device_drivers/ethernet/mellanox/mlx5/counters.html
> 
> Kenta Akagi (1):
>    net/mlx5e: Expose physical received bits counters to ethtool
> 
>   drivers/net/ethernet/mellanox/mlx5/core/en_stats.c | 1 +
>   1 file changed, 1 insertion(+)
> 


  parent reply	other threads:[~2026-01-13  6:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-12  7:03 [PATCH RFC mlx5-next 0/1] net/mlx5e: Expose physical received bits counters to ethtool Kenta Akagi
2026-01-12  7:03 ` [PATCH RFC mlx5-next 1/1] " Kenta Akagi
2026-01-13  6:31 ` Tariq Toukan [this message]
2026-01-13  6:43   ` [PATCH RFC mlx5-next 0/1] " Tariq Toukan
2026-01-13 11:04     ` Kenta Akagi
2026-01-28  7:14       ` Tariq Toukan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0ac69f6a-d587-45a7-be30-6ad4429ef8d2@gmail.com \
    --to=ttoukan.linux@gmail.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=k@mgml.me \
    --cc=kuba@kernel.org \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=mbloch@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=saeedm@nvidia.com \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox