From: David Ahern <dsahern@gmail.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Leon Romanovsky <leonro@mellanox.com>,
netdev <netdev@vger.kernel.org>,
RDMA mailing list <linux-rdma@vger.kernel.org>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH iproute2-next 05/19] rdma: Move resource PD logic to separate file
Date: Fri, 25 Jan 2019 10:19:22 -0700 [thread overview]
Message-ID: <0ad0319f-194c-d574-e7f7-eca71c7a008a@gmail.com> (raw)
In-Reply-To: <20190122183125.15920-6-leon@kernel.org>
On 1/22/19 11:31 AM, Leon Romanovsky wrote:
> +static const
> +struct filters pd_valid_filters[MAX_NUMBER_OF_FILTERS] = {
> + { .name = "dev", .is_number = false },
> + { .name = "users", .is_number = true },
> + { .name = "pid", .is_number = true },
> + { .name = "ctxn", .is_number = true },
> + { .name = "pdn", .is_number = true },
> + { .name = "ctxn", .is_number = true }
> +};
These should not be in a header file. Looks like you have done this in
other patches as well.
next prev parent reply other threads:[~2019-01-25 17:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 18:31 [PATCH iproute2-next 00/19] Export object IDs to users Leon Romanovsky
2019-01-22 18:31 ` [PATCH iproute2-next 01/19] rdma: update uapi headers Leon Romanovsky
2019-01-22 18:31 ` [PATCH iproute2-next 02/19] rdma: Remove duplicated print code Leon Romanovsky
2019-01-22 18:31 ` [PATCH iproute2-next 03/19] rdma: Provide unique indexes for all visible objects Leon Romanovsky
2019-01-22 18:31 ` [PATCH iproute2-next 04/19] rdma: Provide parent context index for all objects except CM_ID Leon Romanovsky
2019-01-22 18:31 ` [PATCH iproute2-next 05/19] rdma: Move resource PD logic to separate file Leon Romanovsky
2019-01-25 17:19 ` David Ahern [this message]
2019-01-27 8:29 ` Leon Romanovsky
2019-01-22 18:31 ` [PATCH iproute2-next 06/19] rdma: Refactor out resource MR " Leon Romanovsky
2019-01-22 18:31 ` [PATCH iproute2-next 07/19] rdma: Move out resource CQ " Leon Romanovsky
2019-01-22 18:31 ` [PATCH iproute2-next 08/19] rdma: Move out resource CM-ID " Leon Romanovsky
2019-01-22 18:31 ` [PATCH iproute2-next 09/19] rdma: Move resource PD " Leon Romanovsky
2019-01-22 18:31 ` [PATCH iproute2-next 10/19] rdma: Properly mark RDMAtool license Leon Romanovsky
2019-01-22 18:31 ` [PATCH iproute2-next 11/19] rdma: Simplify code to reuse existing functions Leon Romanovsky
2019-01-22 18:31 ` [PATCH iproute2-next 12/19] rdma: Simplify CM_ID print code Leon Romanovsky
2019-01-22 18:31 ` [PATCH iproute2-next 13/19] rdma: Refactor CQ prints Leon Romanovsky
2019-01-22 18:31 ` [PATCH iproute2-next 14/19] rdma: Separate MR code Leon Romanovsky
2019-01-22 18:31 ` [PATCH iproute2-next 15/19] rdma: Separate PD code Leon Romanovsky
2019-01-22 18:31 ` [PATCH iproute2-next 16/19] rdma: Move QP code to separate function Leon Romanovsky
2019-01-22 18:31 ` [PATCH iproute2-next 17/19] rdma: Unify netlink attribute checks prior to prints Leon Romanovsky
2019-01-22 18:31 ` [PATCH iproute2-next 18/19] rdma: Perform single .doit call to query specific objects Leon Romanovsky
2019-01-22 18:31 ` [PATCH iproute2-next 19/19] rdma: Provide and reuse filter functions Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ad0319f-194c-d574-e7f7-eca71c7a008a@gmail.com \
--to=dsahern@gmail.com \
--cc=leon@kernel.org \
--cc=leonro@mellanox.com \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).