From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66FB8C282C2 for ; Fri, 25 Jan 2019 17:19:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 318D32083B for ; Fri, 25 Jan 2019 17:19:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a4hC52lr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729129AbfAYRT0 (ORCPT ); Fri, 25 Jan 2019 12:19:26 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:35928 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726252AbfAYRTZ (ORCPT ); Fri, 25 Jan 2019 12:19:25 -0500 Received: by mail-pg1-f195.google.com with SMTP id n2so4469224pgm.3; Fri, 25 Jan 2019 09:19:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=THQRB8P4sfjtQqnB/GevV4LTmAn6oeXkcbPdPqWS2Qw=; b=a4hC52lr5cxCSxEkTsg1iI1nTYIvqEgTm9MDViI8JJvheT5RjDWW8QzIf7XIhPbb6y 7EDVC9EmGiLamQLL/X0Dh5aYaxUFdxnq/OF+XdlFcQqaLkB0dWJKiFPIU8BXtW1KSwh1 W8ZEB0PjYrGyhyMlZyMJoosIsPb9u31SKE0hFUhmQCyG9e634m+nJWtWal8v8weUcocM yT0wMSbi/vlhkvZ0KzqPumz1vg0SriXMc1YgaNlFTzfCXvhsjbVHJipHUNshjfNEPsZi vCM9Hq8YQltJBYFNSOMPCmxgFnYSbe2IjYjlMiYqCockPU0ATQhJoACPA/DGAGx1P1Pw NUQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=THQRB8P4sfjtQqnB/GevV4LTmAn6oeXkcbPdPqWS2Qw=; b=QEH8yPYcTmLan+siE9nh1R303z7GEMdfi8PWyGm3ad54X0ZSiZvrQuJN+2PU7AbY6L EpElgWSrNH8rfktE0T9Y3GvBp+NXPpi8tyrwtlnahzvv/3ed4+7Q5o27ZduWjUBhnRrC tfjauZXmihIfqoEekVBZ2kLmWl0/sRz5C/Y3jKPT40TSVUataD0s5XaDeBwAVxYl9xvl C1VmJafwyGMLTyUyBREzpuuZ8ZoXa1pFR4lVa5HXzaMVnBvZFH7ygmWdAodJKqHcf+8p M2oUBQQTn3XgkwGS5mCsF2QYKcIEUoCoVBIBhsVlUoEFN9V99n/PmM10Hs4Dx/jRDJsK 2+cA== X-Gm-Message-State: AJcUukfv0GdrQM7I4jAKxhoEB5OHTMH4ReOebmFqKpwy93KYh5Z9oDN8 71XYp3TM7Bvs18CEfw3njOU= X-Google-Smtp-Source: ALg8bN5eiH8+9aJ/tjL1q0vo3+P5yXcZ9MpE/+vwNr7PiMAlSj1ypdgwV7WaQ+rMh1CYtSxgIo5P1g== X-Received: by 2002:a65:4683:: with SMTP id h3mr10288875pgr.225.1548436764486; Fri, 25 Jan 2019 09:19:24 -0800 (PST) Received: from ?IPv6:2601:282:800:fd80:795a:c9ad:c0d4:74ef? ([2601:282:800:fd80:795a:c9ad:c0d4:74ef]) by smtp.googlemail.com with ESMTPSA id c23sm30013890pfi.83.2019.01.25.09.19.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Jan 2019 09:19:23 -0800 (PST) Subject: Re: [PATCH iproute2-next 05/19] rdma: Move resource PD logic to separate file To: Leon Romanovsky Cc: Leon Romanovsky , netdev , RDMA mailing list , Stephen Hemminger References: <20190122183125.15920-1-leon@kernel.org> <20190122183125.15920-6-leon@kernel.org> From: David Ahern Message-ID: <0ad0319f-194c-d574-e7f7-eca71c7a008a@gmail.com> Date: Fri, 25 Jan 2019 10:19:22 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190122183125.15920-6-leon@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 1/22/19 11:31 AM, Leon Romanovsky wrote: > +static const > +struct filters pd_valid_filters[MAX_NUMBER_OF_FILTERS] = { > + { .name = "dev", .is_number = false }, > + { .name = "users", .is_number = true }, > + { .name = "pid", .is_number = true }, > + { .name = "ctxn", .is_number = true }, > + { .name = "pdn", .is_number = true }, > + { .name = "ctxn", .is_number = true } > +}; These should not be in a header file. Looks like you have done this in other patches as well.