netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] netdev: Remove unneeded semicolon
@ 2023-09-19  1:03 Yang Li
  2023-09-20 11:10 ` Vadim Fedorenko
  2023-09-21 13:30 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 5+ messages in thread
From: Yang Li @ 2023-09-19  1:03 UTC (permalink / raw)
  To: arkadiusz.kubalewski, jiri; +Cc: netdev, linux-kernel, Yang Li, Abaci Robot

./drivers/dpll/dpll_netlink.c:847:3-4: Unneeded semicolon

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6605
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/dpll/dpll_netlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dpll/dpll_netlink.c b/drivers/dpll/dpll_netlink.c
index 764437a0661b..e20daba6896a 100644
--- a/drivers/dpll/dpll_netlink.c
+++ b/drivers/dpll/dpll_netlink.c
@@ -844,7 +844,7 @@ dpll_pin_find(u64 clock_id, struct nlattr *mod_name_attr,
 				return ERR_PTR(-EINVAL);
 			}
 			pin_match = pin;
-		};
+		}
 	}
 	if (!pin_match) {
 		NL_SET_ERR_MSG(extack, "not found");
-- 
2.20.1.7.g153144c


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH net-next] netdev: Remove unneeded semicolon
  2023-09-19  1:03 [PATCH net-next] netdev: Remove unneeded semicolon Yang Li
@ 2023-09-20 11:10 ` Vadim Fedorenko
  2023-09-21 13:07   ` Paolo Abeni
  2023-09-21 13:30 ` patchwork-bot+netdevbpf
  1 sibling, 1 reply; 5+ messages in thread
From: Vadim Fedorenko @ 2023-09-20 11:10 UTC (permalink / raw)
  To: Yang Li, arkadiusz.kubalewski, jiri; +Cc: netdev, linux-kernel, Abaci Robot

On 19/09/2023 02:03, Yang Li wrote:
> ./drivers/dpll/dpll_netlink.c:847:3-4: Unneeded semicolon
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6605
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Hi Yang!
There was a report from Intel's bot too about the issue, could you 
please add the tags from it?

Reported-by: kernel test robot <lkp@intel.com>
Closes: 
https://lore.kernel.org/oe-kbuild-all/202309190540.RFwfIgO7-lkp@intel.com/

Thanks!

> ---
>   drivers/dpll/dpll_netlink.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dpll/dpll_netlink.c b/drivers/dpll/dpll_netlink.c
> index 764437a0661b..e20daba6896a 100644
> --- a/drivers/dpll/dpll_netlink.c
> +++ b/drivers/dpll/dpll_netlink.c
> @@ -844,7 +844,7 @@ dpll_pin_find(u64 clock_id, struct nlattr *mod_name_attr,
>   				return ERR_PTR(-EINVAL);
>   			}
>   			pin_match = pin;
> -		};
> +		}
>   	}
>   	if (!pin_match) {
>   		NL_SET_ERR_MSG(extack, "not found");


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH net-next] netdev: Remove unneeded semicolon
  2023-09-20 11:10 ` Vadim Fedorenko
@ 2023-09-21 13:07   ` Paolo Abeni
  2023-09-21 14:41     ` Vadim Fedorenko
  0 siblings, 1 reply; 5+ messages in thread
From: Paolo Abeni @ 2023-09-21 13:07 UTC (permalink / raw)
  To: Vadim Fedorenko, Yang Li, arkadiusz.kubalewski, jiri
  Cc: netdev, linux-kernel, Abaci Robot

On Wed, 2023-09-20 at 12:10 +0100, Vadim Fedorenko wrote:
> On 19/09/2023 02:03, Yang Li wrote:
> > ./drivers/dpll/dpll_netlink.c:847:3-4: Unneeded semicolon
> > 
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6605
> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> 
> Hi Yang!
> There was a report from Intel's bot too about the issue, could you 
> please add the tags from it?
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: 
> https://lore.kernel.org/oe-kbuild-all/202309190540.RFwfIgO7-lkp@intel.com/

No need to repost, the pw tools import the above tags automatically.

Cheers,

Paolo


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH net-next] netdev: Remove unneeded semicolon
  2023-09-19  1:03 [PATCH net-next] netdev: Remove unneeded semicolon Yang Li
  2023-09-20 11:10 ` Vadim Fedorenko
@ 2023-09-21 13:30 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-09-21 13:30 UTC (permalink / raw)
  To: Yang Li; +Cc: arkadiusz.kubalewski, jiri, netdev, linux-kernel, abaci

Hello:

This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Tue, 19 Sep 2023 09:03:05 +0800 you wrote:
> ./drivers/dpll/dpll_netlink.c:847:3-4: Unneeded semicolon
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6605
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  drivers/dpll/dpll_netlink.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - [net-next] netdev: Remove unneeded semicolon
    https://git.kernel.org/netdev/net-next/c/f20161cf5165

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH net-next] netdev: Remove unneeded semicolon
  2023-09-21 13:07   ` Paolo Abeni
@ 2023-09-21 14:41     ` Vadim Fedorenko
  0 siblings, 0 replies; 5+ messages in thread
From: Vadim Fedorenko @ 2023-09-21 14:41 UTC (permalink / raw)
  To: Paolo Abeni, Yang Li, arkadiusz.kubalewski, jiri
  Cc: netdev, linux-kernel, Abaci Robot

On 21/09/2023 14:07, Paolo Abeni wrote:
> On Wed, 2023-09-20 at 12:10 +0100, Vadim Fedorenko wrote:
>> On 19/09/2023 02:03, Yang Li wrote:
>>> ./drivers/dpll/dpll_netlink.c:847:3-4: Unneeded semicolon
>>>
>>> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
>>> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6605
>>> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
>>
>> Hi Yang!
>> There was a report from Intel's bot too about the issue, could you
>> please add the tags from it?
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Closes:
>> https://lore.kernel.org/oe-kbuild-all/202309190540.RFwfIgO7-lkp@intel.com/
> 
> No need to repost, the pw tools import the above tags automatically. 

Ok, cool.

The fix itself is trivial.

Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-09-21 17:26 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-19  1:03 [PATCH net-next] netdev: Remove unneeded semicolon Yang Li
2023-09-20 11:10 ` Vadim Fedorenko
2023-09-21 13:07   ` Paolo Abeni
2023-09-21 14:41     ` Vadim Fedorenko
2023-09-21 13:30 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).