From: David Ahern <dsahern@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: ipv4: remove fib_weight
Date: Thu, 28 Sep 2017 07:25:57 -0600 [thread overview]
Message-ID: <0b02a734-38da-5b65-063c-bc861509ff99@gmail.com> (raw)
In-Reply-To: <20170927.215101.2052729160923454927.davem@davemloft.net>
On 9/27/17 10:51 PM, David Miller wrote:
> From: David Ahern <dsahern@gmail.com>
> Date: Wed, 27 Sep 2017 19:08:00 -0700
>
>> fib_weight in fib_info is set but not used. Remove it and the
>> helpers for setting it.
>>
>> Signed-off-by: David Ahern <dsahern@gmail.com>
>
> Hmmm, I wonder then what Peter intended in commit
> 0e884c78ee19e902f300ed147083c28a0c6302f0 ("ipv4: L3 hash-based
> multipath") because that's where this came from.
>
You can see that fib_weight is set but not used in his patch either.
Perhaps it was an early idea that was replaced by the per-nexthop
nh_upper_bound and that code was not removed.
next prev parent reply other threads:[~2017-09-28 13:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 2:08 [PATCH net-next] net: ipv4: remove fib_weight David Ahern
2017-09-28 4:51 ` David Miller
2017-09-28 13:25 ` David Ahern [this message]
2017-09-29 5:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b02a734-38da-5b65-063c-bc861509ff99@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).