From: Paolo Abeni <pabeni@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>, netdev@vger.kernel.org
Cc: Jay Vosburgh <j.vosburgh@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>,
Johannes Berg <johannes.berg@intel.com>,
Jiri Pirko <jiri@nvidia.com>
Subject: Re: [PATCH net-next] net: bonding: correctly annotate RCU in bond_should_notify_peers()
Date: Tue, 23 Jul 2024 12:25:23 +0200 [thread overview]
Message-ID: <0b0cb62e-4e10-458e-8d21-8a082f94aa4d@redhat.com> (raw)
In-Reply-To: <20240719094119.35c62455087d.I68eb9c0f02545b364b79a59f2110f2cf5682a8e2@changeid>
On 7/19/24 18:41, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> RCU use in bond_should_notify_peers() looks wrong, since it does
> rcu_dereference(), leaves the critical section, and uses the
> pointer after that.
>
> Luckily, it's called either inside a nested RCU critical section
> or with the RTNL held.
>
> Annotate it with rcu_dereference_rtnl() instead, and remove the
> inner RCU critical section.
>
> Fixes: 4cb4f97b7e36 ("bonding: rebuild the lock use for bond_mii_monitor()")
> Reviewed-by: Jiri Pirko <jiri@nvidia.com>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Any special reasons to target net-next? this looks like a legit net fix
to me. If you want to target net, no need to re-post, otherwise it will
have to wait the merge window end.
Thanks,
Paolo
next prev parent reply other threads:[~2024-07-23 10:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-19 16:41 [PATCH net-next] net: bonding: correctly annotate RCU in bond_should_notify_peers() Johannes Berg
2024-07-21 17:09 ` Jay Vosburgh
2024-07-23 10:25 ` Paolo Abeni [this message]
2024-07-23 11:30 ` Johannes Berg
2024-07-23 13:12 ` Paolo Abeni
2024-07-23 13:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b0cb62e-4e10-458e-8d21-8a082f94aa4d@redhat.com \
--to=pabeni@redhat.com \
--cc=andy@greyhouse.net \
--cc=j.vosburgh@gmail.com \
--cc=jiri@nvidia.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).