From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65D5EC43381 for ; Fri, 15 Mar 2019 14:58:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 318A2218B0 for ; Fri, 15 Mar 2019 14:58:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tLD0LTiQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728643AbfCOO6O (ORCPT ); Fri, 15 Mar 2019 10:58:14 -0400 Received: from mail-pf1-f182.google.com ([209.85.210.182]:45410 "EHLO mail-pf1-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727013AbfCOO6O (ORCPT ); Fri, 15 Mar 2019 10:58:14 -0400 Received: by mail-pf1-f182.google.com with SMTP id v21so6513957pfm.12 for ; Fri, 15 Mar 2019 07:58:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=EMsCKcZPEY63E6g8XFNiPF7Tdqjvy/bkzOB5Rc6beIk=; b=tLD0LTiQZrnHoQLDDMeX2Co9gaLI/haqQa9c5IsLm0df5n5buvESomeKJAjpwYg5eZ 8q1Ss7vfT+KONtDRkwA9EtFLv1+CTF7N6OeJRlWnD5HKmNHpVBo9YNeeTB+s21spuRBy AYTd67aW8wHkqxu8uGWiAKJlZ8Q1MmdxKiwBl41OWiSsLYm1bABizvXtzkegZbmedi0w +Py/l8r29unXLC/sN37zUsTTQHDSjFDZWWUN/8VgWQT3s6dTmq0YJLu9kqMNr2e7a5SI D+Q20RK1a7oJXdtNTFV0+cPtHqfmrV/z4+GBdWh+85d47YWVoAgJ57zcFlgOrKs1SOUa l3MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EMsCKcZPEY63E6g8XFNiPF7Tdqjvy/bkzOB5Rc6beIk=; b=g2mNlfnRtAiI11RkozhMbS2+dIBinAFBLriHR7avxBq4qMVAr37ptO7iRequLdvD2N 3Jd+HLywbTF7PW97+w6TuJpTV12m7Ol5zCgiewLnZeLb+w1FjmPfrwxMVpwt3F679rvK mJnZOVO2yVE73ebpXz+ZGXPH1JQlw7SUbmEMDlKl4CAI1lDbeEnGoa8mmV1L50r5WWf8 7+R38Sz3G+mg2CkF3uXEYjkdQWU8gFHG1mXKanYbrGu/EqjfOM1XuR33Y2e8lKw3Ckjq GPIpdA4kfJANQ5Ao/m+amFKhHmnKc/lKRAof18CfZLJcLAeRZW4SU3fhc99ybudrBGJ6 R1Gg== X-Gm-Message-State: APjAAAXp3/JJpjfiH4WAnTcHiXwgocd9RtX6VtwYthcuAoSVqI8muqvq q1KV3FUIN1b2N+p7Rd6oH31MKvgo X-Google-Smtp-Source: APXvYqzO3tlfBuWW9NIrnCIInWhafJWOli3LiXXONQT5WTrzuvMHCjoEzul87GtV2Vld7z1nNu9pOg== X-Received: by 2002:a63:65c4:: with SMTP id z187mr3827003pgb.102.1552661893650; Fri, 15 Mar 2019 07:58:13 -0700 (PDT) Received: from [192.168.84.16] (216.sub-166-144-35.myvzw.com. [166.144.35.216]) by smtp.gmail.com with ESMTPSA id z77sm6304078pfi.155.2019.03.15.07.58.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Mar 2019 07:58:12 -0700 (PDT) Subject: Re: [PATCH] vxlan: remove the redundant gro_cells_destroy() calling. To: Zhiqiang Liu , davem@davemloft.net, petrm@mellanox.com, idosch@mellanox.com, sd@queasysnail.net, sbrivio@redhat.com, mousuanming@huawei.com Cc: netdev@vger.kernel.org, Mingfangsen , "Zhoukang (A)" , "wangxiaogang (F)" References: <2276c137-d5c0-bdbe-f5c7-5985ffc497ce@huawei.com> From: Eric Dumazet Message-ID: <0b4b114d-f650-839e-40ee-49c4d7c3248c@gmail.com> Date: Fri, 15 Mar 2019 07:58:10 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <2276c137-d5c0-bdbe-f5c7-5985ffc497ce@huawei.com> Content-Type: text/plain; charset=gbk Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 03/15/2019 03:06 AM, Zhiqiang Liu wrote: > From: "Suanming.Mou" > > With ad6c9986bcb6, GRO cells will be destroyed in vxlan_uninit. > > Fixes: ad6c9986bcb6 ("vxlan: Fix GRO cells race condition between receive and link delete") > This is a net-next candidate . The Fixes: tag is not needed, the cited commit added no bug.