From: Andrew Lunn <andrew@lunn.ch>
To: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: netdev@vger.kernel.org, Mengyuan Lou <mengyuanlou@net-swift.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Kees Cook <kees@kernel.org>,
Chenguang Zhao <zhaochenguang@kylinos.cn>,
"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
Simon Horman <horms@kernel.org>
Subject: Re: [PATCH net 2/3] net: txgbe: keep MAC enabled for NCSI and WoL for SP devices
Date: Sun, 20 Sep 2026 16:56:24 +0200 [thread overview]
Message-ID: <0b4c65e5-b2c3-4c8b-9db7-d221ffab6ec5@lunn.ch> (raw)
In-Reply-To: <F55611137A66BAC3+20260920085114.1062503-2-jiawenwu@trustnetic.com>
On Sun, Sep 20, 2026 at 04:51:13PM +0800, Jiawen Wu wrote:
> The .mac_link_down() in phylink callback disable MAC TX unconditionally.
> This is not suitable for devices using NCSI or WoL, where the MAC needs
> to remain enbaled after the link goes down to support the corresponding
> functionality.
>
> Skip disabling MAC TX when the subsystem device ID indicates an NCSI or
> WoL device. Keep the existing link-down handling for other devices.
NCSI i can understand, but phylink knows about WoL. This makes me
think your WoL code is broken. Please review it.
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2026-09-20 14:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260920085114.1062503-1-jiawenwu@trustnetic.com>
2026-09-20 8:51 ` [PATCH net 2/3] net: txgbe: keep MAC enabled for NCSI and WoL for SP devices Jiawen Wu
2026-09-20 14:56 ` Andrew Lunn [this message]
2026-09-21 2:22 ` Jiawen Wu
2026-09-21 12:53 ` Andrew Lunn
2026-09-20 8:51 ` [PATCH net 3/3] net: txgbe: keep MAC enabled for NCSI and WoL for AML devices Jiawen Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b4c65e5-b2c3-4c8b-9db7-d221ffab6ec5@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=jiawenwu@trustnetic.com \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=zhaochenguang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox