From: Eli Britstein <elibr@mellanox.com>
To: David Miller <davem@davemloft.net>, "pshelar@ovn.org" <pshelar@ovn.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"blp@ovn.org" <blp@ovn.org>,
"dev@openvswitch.org" <dev@openvswitch.org>,
Roi Dayan <roid@mellanox.com>,
"simon.horman@netronome.com" <simon.horman@netronome.com>
Subject: Re: [PATCH net-next 1/1] openvswitch: Declare ovs key structures using macros
Date: Thu, 31 Jan 2019 11:32:02 +0000 [thread overview]
Message-ID: <0b6faaac-e0ea-b2a4-e8a3-42e48436ed1d@mellanox.com> (raw)
In-Reply-To: <b9632d46-91f7-49a9-3f32-76ada6317da9@mellanox.com>
ping
for the using patch, i put below the v1 of it. here is v2:
https://patchwork.ozlabs.org/patch/1023406/
On 1/27/2019 8:37 AM, Eli Britstein wrote:
>
> On 1/27/2019 1:04 AM, David Miller wrote:
>> From: Eli Britstein <elibr@mellanox.com>
>> Date: Thu, 24 Jan 2019 11:46:47 +0200
>>
>>> Declare ovs key structures using macros to enable retrieving fields
>>> information, with no functional change.
>>>
>>> Signed-off-by: Eli Britstein <elibr@mellanox.com>
>>> Reviewed-by: Roi Dayan <roid@mellanox.com>
>> I agree with Pravin, this need a much better commit message.
>>
>> Maybe even better to submit this alongside whatever is supposed
>> to use these new macros.
>
> This patch is equivalent to a work done in the OVS tree.
>
> https://patchwork.ozlabs.org/patch/1023405/
>
> As a standalone it doesn't serve any purpose (as mentioned - no
> functional change).
>
> It serves as a pre-step towards another patch in the OVS:
>
> https://patchwork.ozlabs.org/patch/1022794/
>
> So, the purpose of doing it in the kernel is just to keep this H file
> identical. Once it is approved for the kernel, we will be able to
> proceed with it in the OVS.
>
next prev parent reply other threads:[~2019-01-31 11:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 9:46 [PATCH net-next 1/1] openvswitch: Declare ovs key structures using macros Eli Britstein
2019-01-25 21:55 ` Pravin Shelar
2019-01-26 23:04 ` David Miller
2019-01-27 6:37 ` Eli Britstein
2019-01-31 11:32 ` Eli Britstein [this message]
2019-02-01 2:39 ` Pravin Shelar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b6faaac-e0ea-b2a4-e8a3-42e48436ed1d@mellanox.com \
--to=elibr@mellanox.com \
--cc=blp@ovn.org \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
--cc=roid@mellanox.com \
--cc=simon.horman@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox