From: Paolo Abeni <pabeni@redhat.com>
To: Daniel Yang <danielyangkang@gmail.com>,
Martin KaFai Lau <martin.lau@linux.dev>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
John Fastabend <john.fastabend@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>, Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
"open list:BPF [NETWORKING] (tcx & tc BPF,
sock_addr)" <bpf@vger.kernel.org>,
"open list:BPF [NETWORKING] (tcx & tc BPF,
sock_addr)" <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
syzbot+346474e3bf0b26bd3090@syzkaller.appspotmail.com
Subject: Re: [PATCH net] Drop packets with invalid headers to prevent KMSAN infoleak
Date: Tue, 22 Oct 2024 17:30:28 +0200 [thread overview]
Message-ID: <0b779b4d-d2d3-499e-abf9-4eae4806316b@redhat.com> (raw)
In-Reply-To: <CAGiJo8R2PhpOitTjdqZ-jbng0Yg=Lxu6L+6FkYuUC1M_d10U2Q@mail.gmail.com>
On 10/22/24 03:37, Daniel Yang wrote:
> Are there any possible unexpected issues that can be caused by this?
This patch is apparently the cause of BPF self-tests failures:
test_empty_skb:FAIL:ret: veth ETH_HLEN+1 packet ingress
[redirect_ingress] unexpected ret: veth ETH_HLEN+1 packet ingress
[redirect_ingress]: actual -34 != expected 0
test_empty_skb:PASS:err: veth ETH_HLEN+1 packet ingress
[redirect_egress] 0 nsec
test_empty_skb:FAIL:ret: veth ETH_HLEN+1 packet ingress
[redirect_egress] unexpected ret: veth ETH_HLEN+1 packet ingress
[redirect_egress]: actual -34 != expected 1
Before submitting an eventual next revision, please very that BPF
self-tests are happy.
Thanks,
Paolo
next prev parent reply other threads:[~2024-10-22 15:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-19 7:11 [PATCH net] Drop packets with invalid headers to prevent KMSAN infoleak Daniel Yang
2024-10-21 22:25 ` Martin KaFai Lau
2024-10-22 1:37 ` Daniel Yang
2024-10-22 15:30 ` Paolo Abeni [this message]
2024-10-22 18:14 ` Martin KaFai Lau
2024-10-27 8:49 ` Daniel Yang
2024-10-28 5:42 ` Yonghong Song
2024-10-29 21:23 ` Daniel Yang
2024-10-29 16:40 ` Alexander Lobakin
2024-10-29 21:34 ` Daniel Yang
-- strict thread matches above, loose matches on Subject: below --
2024-11-04 4:02 Daniel Yang
2024-11-04 10:03 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b779b4d-d2d3-499e-abf9-4eae4806316b@redhat.com \
--to=pabeni@redhat.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=danielyangkang@gmail.com \
--cc=davem@davemloft.net \
--cc=eddyz87@gmail.com \
--cc=edumazet@google.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=syzbot+346474e3bf0b26bd3090@syzkaller.appspotmail.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).