From: Eric Dumazet <eric.dumazet@gmail.com>
To: Steffen Klassert <steffen.klassert@secunet.com>,
Florian Westphal <fw@strlen.de>
Cc: vakul.garg@nxp.com, netdev@vger.kernel.org,
Eric Dumazet <edumazet@google.com>
Subject: Re: [RFC HACK] xfrm: make state refcounting percpu
Date: Fri, 3 May 2019 08:06:05 -0400 [thread overview]
Message-ID: <0b998948-d89f-21bf-f76a-9c2b96dffd1d@gmail.com> (raw)
In-Reply-To: <20190503060748.GK17989@gauss3.secunet.de>
On 5/3/19 2:07 AM, Steffen Klassert wrote:
> On Wed, Apr 24, 2019 at 12:40:23PM +0200, Florian Westphal wrote:
>> I'm not sure this is a good idea to begin with, refcount
>> is right next to state spinlock which is taken for both tx and rx ops,
>> plus this complicates debugging quite a bit.
>
>
For some reason I have not received Florian response.
Florian, when the percpu counters are in nominal mode,
the updates are only in percpu memory, so the cache line containing struct percpu_ref in the
main object is not dirtied.
(This field/object can be placed in a read-mostly location of the structure if needed)
I would definitely try to use this.
next prev parent reply other threads:[~2019-05-03 12:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-22 14:29 ipsec tunnel performance degrade Vakul Garg
2019-04-22 17:45 ` Florian Westphal
2019-04-23 2:36 ` Vakul Garg
2019-04-23 5:56 ` Florian Westphal
2019-04-23 15:04 ` Vakul Garg
2019-04-23 16:25 ` Florian Westphal
2019-04-23 17:27 ` David Miller
2019-04-24 7:32 ` Vakul Garg
2019-04-24 10:40 ` [RFC HACK] xfrm: make state refcounting percpu Florian Westphal
2019-04-24 11:38 ` Eric Dumazet
2019-05-03 6:07 ` Steffen Klassert
2019-05-03 6:13 ` Vakul Garg
2019-05-03 6:22 ` Steffen Klassert
2019-05-03 6:34 ` Vakul Garg
2019-05-03 6:46 ` Steffen Klassert
2019-05-03 6:48 ` Vakul Garg
2019-05-03 12:06 ` Eric Dumazet [this message]
2019-05-03 15:55 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b998948-d89f-21bf-f76a-9c2b96dffd1d@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=vakul.garg@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).