netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bo Sun <bo@mboxify.com>
To: Simon Horman <horms@kernel.org>
Cc: sgoutham@marvell.com, gakula@marvell.com, kuba@kernel.org,
	pabeni@redhat.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/2] octeontx2-vf: fix bitmap leak
Date: Mon, 29 Sep 2025 22:49:54 +0800	[thread overview]
Message-ID: <0bb6cec0e6bcf22a43bfff4b0813b201@mboxify.com> (raw)
In-Reply-To: <aNpbZkQZxa3HkrJj@horms.kernel.org>

On 2025-09-29 18:11, Simon Horman wrote:
> On Sat, Sep 27, 2025 at 03:15:04PM +0800, Bo Sun wrote:
>> The bitmap allocated with bitmap_zalloc() in otx2vf_probe() was not
>> released in otx2vf_remove(). Unbinding and rebinding the driver 
>> therefore
>> triggers a kmemleak warning:
>> 
>>     unreferenced object (size 8):
>>       backtrace:
>>         bitmap_zalloc
>>         otx2vf_probe
>> 
>> Call bitmap_free() in the remove path to fix the leak.
>> 
>> Fixes: efabce290151 ("octeontx2-pf: AF_XDP zero copy receive support")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Bo Sun <bo@mboxify.com>
> 
> Reviewed-by: Simon Horman <horms@kernel.org>
> 
> For reference, as a fix for code present in net, this series
> should be targeted at net, like this:
> 
> Subject: [PATCH net 1/2] ...
> 
> See: https://docs.kernel.org/process/maintainer-netdev.html

Thanks for pointing this out.
I’ll resend v2 for the net tree with the correct subject prefix.

Best regards,
Bo

  reply	other threads:[~2025-09-29 14:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-27  7:15 [PATCH 0/2] octeontx2: fix bitmap leaks in PF and VF Bo Sun
2025-09-27  7:15 ` [PATCH 1/2] octeontx2-vf: fix bitmap leak Bo Sun
2025-09-29 10:11   ` Simon Horman
2025-09-29 14:49     ` Bo Sun [this message]
2025-09-30  1:53       ` Jakub Kicinski
2025-09-30  5:46         ` Bo Sun
2025-09-27  7:15 ` [PATCH 2/2] octeontx2-pf: " Bo Sun
2025-09-29 10:12   ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0bb6cec0e6bcf22a43bfff4b0813b201@mboxify.com \
    --to=bo@mboxify.com \
    --cc=gakula@marvell.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sgoutham@marvell.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).