From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Jakub Kicinski <kuba@kernel.org>, <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <edumazet@google.com>, <pabeni@redhat.com>
Subject: Re: [PATCH net-next 1/3] net: docs: update the sample code in driver.rst
Date: Tue, 11 Apr 2023 08:52:03 -0700 [thread overview]
Message-ID: <0bc0fc8c-a09d-3310-995f-f44e67a9ab54@intel.com> (raw)
In-Reply-To: <20230411013323.513688-2-kuba@kernel.org>
On 4/10/2023 6:33 PM, Jakub Kicinski wrote:
> The sample code talks about single-queue devices and uses locks.
> Update it to something resembling more modern code.
> Make sure we mention use of READ_ONCE() / WRITE_ONCE().
>
> Change the comment which talked about consumer on the xmit side.
> AFAIU xmit is the producer and completions are a consumer.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
much better docs, and I'm really happy to see more documentation about
using (READ|WRITE)_ONCE()
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
next prev parent reply other threads:[~2023-04-11 15:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 1:33 [PATCH net-next 0/3] net: use READ_ONCE/WRITE_ONCE for ring index accesses Jakub Kicinski
2023-04-11 1:33 ` [PATCH net-next 1/3] net: docs: update the sample code in driver.rst Jakub Kicinski
2023-04-11 15:52 ` Jesse Brandeburg [this message]
2023-04-11 1:33 ` [PATCH net-next 2/3] bnxt: use READ_ONCE/WRITE_ONCE for ring indexes Jakub Kicinski
2023-04-11 15:52 ` Jesse Brandeburg
2023-04-11 23:09 ` Michael Chan
2023-04-11 1:33 ` [PATCH net-next 3/3] mlx4: " Jakub Kicinski
2023-04-11 15:52 ` Jesse Brandeburg
2023-04-11 15:55 ` [PATCH net-next 0/3] net: use READ_ONCE/WRITE_ONCE for ring index accesses Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bc0fc8c-a09d-3310-995f-f44e67a9ab54@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).