From: Rick Lindsley <ricklind@linux.vnet.ibm.com>
To: Lijun Pan <lijunp213@gmail.com>, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: ibm: replenish rx pool and poll less frequently
Date: Wed, 2 Jun 2021 10:47:27 -0700 [thread overview]
Message-ID: <0bddd39e-b6da-2c69-fd37-a08bd5a1e18b@linux.vnet.ibm.com> (raw)
In-Reply-To: <20210602170156.41643-1-lijunp213@gmail.com>
On 6/2/21 10:01 AM, Lijun Pan wrote:
> The old mechanism replenishes rx pool even only one frames is processed in
> the poll function, which causes lots of overheads. The old mechanism
> restarts polling until processed frames reaches the budget, which can
> cause the poll function to loop into restart_poll 63 times at most and to
> call replenish_rx_poll 63 times at most.
Presumably this frequency is to keep ahead of demand. When you say lots
of overhead - can you attach a number to that? How much does this change
improve on that number (what workload benefits?)
next prev parent reply other threads:[~2021-06-02 17:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 17:01 [PATCH net-next] net: ibm: replenish rx pool and poll less frequently Lijun Pan
2021-06-02 17:47 ` Rick Lindsley [this message]
2021-06-02 17:58 ` Dany Madden
2021-06-02 18:23 ` Dany Madden
2021-06-02 19:25 ` Sukadev Bhattiprolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bddd39e-b6da-2c69-fd37-a08bd5a1e18b@linux.vnet.ibm.com \
--to=ricklind@linux.vnet.ibm.com \
--cc=lijunp213@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).