From: Paolo Abeni <pabeni@redhat.com>
To: Allison Henderson <achender@kernel.org>, netdev@vger.kernel.org
Cc: allison.henderson@oracle.com
Subject: Re: [PATCH net-next v1 2/2] net/rds: Give each connection its own workqueue
Date: Tue, 4 Nov 2025 15:57:25 +0100 [thread overview]
Message-ID: <0bee7457-eddc-493f-bdb9-a438347958f9@redhat.com> (raw)
In-Reply-To: <20251029174609.33778-3-achender@kernel.org>
On 10/29/25 6:46 PM, Allison Henderson wrote:
> From: Allison Henderson <allison.henderson@oracle.com>
>
> RDS was written to require ordered workqueues for "cp->cp_wq":
> Work is executed in the order scheduled, one item at a time.
>
> If these workqueues are shared across connections,
> then work executed on behalf of one connection blocks work
> scheduled for a different and unrelated connection.
>
> Luckily we don't need to share these workqueues.
> While it obviously makes sense to limit the number of
> workers (processes) that ought to be allocated on a system,
> a workqueue that doesn't have a rescue worker attached,
> has a tiny footprint compared to the connection as a whole:
> A workqueue costs ~800 bytes, while an RDS/IB connection
> totals ~5 MBytes.
Still a workqueue per connection feels overkill. Have you considered
moving to WQ_PERCPU for rds_wq? Why does not fit?
Thanks,
Paolo
next prev parent reply other threads:[~2025-11-04 14:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 17:46 [PATCH net-next v1 0/2] net/rds: RDS-TCP bug fix collection, subset 1: Work queue scalability Allison Henderson
2025-10-29 17:46 ` [PATCH net-next v1 1/2] net/rds: Add per cp work queue Allison Henderson
2025-10-29 17:46 ` [PATCH net-next v1 2/2] net/rds: Give each connection its own workqueue Allison Henderson
2025-11-04 14:57 ` Paolo Abeni [this message]
2025-11-04 21:23 ` Allison Henderson
2025-11-06 10:52 ` Paolo Abeni
2025-11-08 1:24 ` Allison Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bee7457-eddc-493f-bdb9-a438347958f9@redhat.com \
--to=pabeni@redhat.com \
--cc=achender@kernel.org \
--cc=allison.henderson@oracle.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).