From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.45 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794565649; b=iHCbYuFgcdyILyGtAr7CVjO2ZbHJsb8QVShTnvUNjSSNEZ0Glop0c7+iytnCNURRE2eb W621uHwVekz07HRthaIRKXxQNsU5eP1ydKmF3OGdr3+IkKl0K/wTK2jDii+2iok5VJyhh 4AJcGoBFu4d6ZDMYd/t5VsW+YL8hKyVsOC1Jgcd15BuggDFdtB4ceG8R8MZPbim7UdEu6 zyPcTrzYzeuLgyxQryBf62oDHf/imoGrr4A1TVrwWC8xgcqYCHFxwmZ911YBBGCxtxu1h jRvWejMox4LEyr4GnhogXU90d+juryNSvOVUq/8cQa5iZMqXp9neJAfRwMJy1EROG0w== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794565649; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:Content-Transfer-Encoding:User-Agent:MIME-Version; bh=TXY31nY7nMCHyiOZTp7Dn0JSWYPda+tFg8CPAdTq7II=; b=CBwoOlJuzrqPhicPjYBtTpLSMLci59vPqd5wfvQM2HrXUChrFtwu8bfZVsGfS3IWPABv MJJx1KkkZwj93indD+zeOYYRKK2uCNQcpBK52i0186HRe6/oghGHqydQo9w95YS24Zpwn hYIpFK+nwt5Jpy5VDgjELg4nY36NAkTCluP0FxZikJz6gOgCU7kdgn2gq+9kQ5I9sdEM7 WHbbe1KKN/ADFXU8ehv6QaWJdTFPpqmkY5FXqljv4Tzh31H7p5UnJkzUCT3RPq4m65EYh 4CpYx+408bairVXpWSvTIiFJQJRwRVMTsG+NvJDSuDNudreWqJ0NMgaKGwSJfwlw2CA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=amutable.com; spf=pass smtp.mailfrom=amutable.com; dkim=pass header.d=amutable-com.20260707.gappssmtp.com header.i=@amutable-com.20260707.gappssmtp.com header.a=rsa-sha256 header.s=20260707 header.b=N7Ff61ik; arc=none smtp.remote-ip=209.85.221.45 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E763606A333 for ; Fri, 13 Nov 2026 10:27:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 4E763606A333 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=amutable.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amutable.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=amutable-com.20260707.gappssmtp.com header.i=@amutable-com.20260707.gappssmtp.com header.a=rsa-sha256 header.s=20260707 header.b=N7Ff61ik Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-48fd2e38825so516942f8f.2 for ; Fri, 13 Nov 2026 02:27:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amutable-com.20260707.gappssmtp.com; s=20260707; t=1794565647; x=1795170447; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to:content-type; bh=TXY31nY7nMCHyiOZTp7Dn0JSWYPda+tFg8CPAdTq7II=; b=N7Ff61ikIQ27nXVrR+i5fFuiFp+kpNCkSJ8kzzwXsWXF8oHPQYaaEtIn2sVJ/R61Yt eN/EgbWtaqyPzsaKr2MVnoSj+msmKBheiZS6yCjGNfIw7Nev7hKixHBvdeyifMwCAuyY p4HuC2pLhsdw/6s4IDRTQYVk2XreSuuUeA2/lEtpnIKw65+UPm9cBNCU3JmsoFXsrPGj WUoovGImF4s4dFS6xRIsBa0e81egoKAVqgb5m7AbWjvbiu6rsFasaFfPaH+ik5AAKzYn 61DshIaK40jfv3WiwMjZKKDrEIOQNGX/IDgIqQj4sI1tIu9ZETTA/xF/QESgBcPouNO3 9yyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794565647; x=1795170447; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=TXY31nY7nMCHyiOZTp7Dn0JSWYPda+tFg8CPAdTq7II=; b=ZiINLLk7H5oEBjIFFQF8Kt3tQmK0SPcArAxLS183uL56bWN0gexwvlBNrjbsHTfiEg qz0dI17qkekcQhd3K6dXTeNMtnFALPKp2E/jMGai+0BSH5V9+f1rFsrurGouSl+XZfQd sfPpBbm4cMm8ZiX1Cr8hDMnPYJhwYbMTgxBAPVEQjG8Ie1MDL3260WT/50BxNWcl93D7 bwauk5SZ01B0UcDjjc1tgvFQL4b3yyOQiBXbLlxz43r4VCJEk7wQFxJSPcrhoKZ73ZRV sYP/5RfwOEbN4DdvubLReXc22Gl33xSLF92e9ZlwHiqLo63SJGUBMEBrqGv8yH9tGQZT MmWg== X-Forwarded-Encrypted: i=1; AL+hErFkDvgdKDXEXFkyRyjVeD7JbQ/o7lF8P+6WKl40lS19DXkpJaLz8CGXb5SqFgJaZJ5JuxyOdSw=@vger.kernel.org X-Gm-Message-State: APuU4Z+hbv8yy6fjydNlQN6YOK/EErDUfjEIrRXk1VzrYC6igWSXx29I bo30HbceTmkZbX85h7n73r8Ku1ShbUG/nnZOiHuBVhB4T5mXrFC3Ra5KeEGFWPHKPcY9 X-Gm-Gg: AYBFou3GuUIFi1JOfWjkmcPnidvdgX47PV5DyMc+U/cK8WTYxllRYepAda20K+CeGTS kgy6rjHQlxC1zirfO0+F3jZ0VK6iWnzeZDnVgIKBxVidKxH0lNvBfg0h82x9JkZJVbb9bQYkX0D HeQupgDgBFJxL5G1Q/FK1obgwA8pcDYSqAUawgNCPLSXPoqMaCxwfzruLOlLe2YIY8w9Yk/BTfg MvC1qUuIIpk5qIZSItAmfqW9OAPOHrQe4nwv+jbya7ZIXkRXTwxooDZAp3ZdFaV7hEwfvwQJwEl mKSyRldSbNZZ8voAT43/rW//1FEXWjCLsqEV1T5D038PY++lYeXvarZoJlzTxMsMmRvoJy/cOeB h3RjXL/+UGXLh5965qIQ8R04xSSa8gZ9o68DqjZrWQkXDYadzgs49/25oeUMJVhwOz/mIoyzA93 6ozNueRyB/Ptel3R8EWdrgMTsEOGcMxy/tckPC6ZQvm7w37hrXF152Hhh+xkFYKK1aoIzth+ofn Y9Zh0Afu5qDcbv/kBJWGLpsXnKFHQuM61ARoY7q1KpySUHa0vE2tFADVjU2T15oaf8KxMSG/GIQ bANjcb/TKT71jGASXDtok1IDRRPNgGKy82WVomwgnTzP/HUnK7PrDoFfwlNSe+8= X-Received: by 2002:a05:6000:4707:b0:498:c419:3728 with SMTP id ffacd0b85a97d-49c713ae367mr4463557f8f.22.1794565646661; Fri, 13 Nov 2026 02:27:26 -0800 (PST) Received: from [10.0.0.233] (tmo-086-54.customers.d1-online.com. [80.187.86.54]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-49c5a32d336sm5077482f8f.0.2026.11.13.02.27.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Nov 2026 02:27:26 -0800 (PST) Message-ID: <0c109a58804a2d782e549af6ad13e89532d9f9d2.camel@amutable.com> Subject: Re: [PATCH RFC 40/41] erofs: refuse files on pseudo filesystems as backing files From: Alexander Mikhalitsyn To: Christian Brauner , linux-fsdevel@vger.kernel.org Cc: Jann Horn , Chris Mason , Josef Bacik , Christoph Hellwig , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Alexander Viro , Jan Kara , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, driver-core@lists.linux.dev, linux-mm@kvack.org, bpf@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, apparmor@lists.ubuntu.com, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, fuse-devel@lists.linux.dev, linux-efi@vger.kernel.org, xen-devel@lists.xenproject.org, ocfs2-devel@lists.linux.dev, linux-s390@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-usb@vger.kernel.org, Amir Goldstein , linux-erofs@lists.ozlabs.org, linux-kselftest@vger.kernel.org Date: Fri, 13 Nov 2026 11:27:24 +0100 In-Reply-To: <20261110-work-loop-pseudo-v1-40-4c998976c6c7@kernel.org> References: <20261110-work-loop-pseudo-v1-0-4c998976c6c7@kernel.org> <20261110-work-loop-pseudo-v1-40-4c998976c6c7@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-0+deb13u1 X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 On Tue, 2026-11-10 at 10:14 +0100, Christian Brauner wrote: > File-backed mounts take any regular file as the image and the same > goes > for the extra devices of such a mount. erofs reads them with the > credentials of the mounter so this doesn't hand out anything the > mounter > couldn't read anyway. But files on pseudo filesystems aren't images. > Refuse them just like loop does. >=20 > Signed-off-by: Christian Brauner (Amutable) Reviewed-by: Alexander Mikhalitsyn > --- > =C2=A0fs/erofs/super.c | 6 +++++- > =C2=A01 file changed, 5 insertions(+), 1 deletion(-) >=20 > diff --git a/fs/erofs/super.c b/fs/erofs/super.c > index ce05557bd998..980d5fc2b576 100644 > --- a/fs/erofs/super.c > +++ b/fs/erofs/super.c > @@ -158,7 +158,8 @@ static int erofs_init_device(struct erofs_buf > *buf, struct super_block *sb, > =C2=A0 if (!erofs_is_fileio_mode(sbi)) { > =C2=A0 dif->dax_dev =3D > fs_dax_get_by_bdev(file_bdev(file), > =C2=A0 &dif->dax_part_off, NULL, > NULL); > - } else if (!S_ISREG(file_inode(file)->i_mode)) { > + } else if (!S_ISREG(file_inode(file)->i_mode) || > + =C2=A0=C2=A0 file_is_pseudo(file)) { > =C2=A0 fput(file); > =C2=A0 return -EINVAL; > =C2=A0 } > @@ -835,6 +836,9 @@ static int erofs_file_get_tree(struct fs_context > *fc) > =C2=A0{ > =C2=A0 struct erofs_sb_info *sbi =3D fc->s_fs_info; > =C2=A0 > + if (file_is_pseudo(sbi->dif0.file)) > + return invalfc(fc, "source is on a pseudo > filesystem"); > + > =C2=A0 if (!test_opt(&sbi->opt, SUPERBLOCK_SHARE)) > =C2=A0 return get_tree_nodev(fc, erofs_fc_fill_super); > =C2=A0